zendesk/zendesk_api_client_rb

View on GitHub
util/resource_handler.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method process has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def process
    many = statement.jump(:ident).source == "has_many"

    klass = get_klass(statement)

Severity: Minor
Found in util/resource_handler.rb - About 1 hr to fix

    Method process has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def process
        many = statement.jump(:ident).source == "has_many"
    
        klass = get_klass(statement)
    
    
    Severity: Minor
    Found in util/resource_handler.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_klass has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_klass(statement)
        statement.traverse do |node|
          if node.type == :assoc && node.jump(:kw).source == "class"
            node.traverse do |value|
              if value.type == :const_path_ref || value.type == :var_ref
    Severity: Minor
    Found in util/resource_handler.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status