Sign upLogin

zephir/luya

View on GitHub
Star

Showing 90 of 90 total issues

File intersectionObserver.polyfill.src.js has 869 lines of code (exceeds 250 allowed). Consider refactoring.
Open

if (!window.getComputedStyle) {
  /**
   * @param {(Element|null)} e
   * @param {(null|string)=} t
   * @return {(CSSStyleDeclaration|null)}
Severity: Major
Found in core/resources/lazyload/intersectionObserver.polyfill.src.js - About 2 days to fix

    File CreativeWorkTrait.php has 686 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace luya\web\jsonld;

use luya\helpers\ObjectHelper;
    Severity: Major
    Found in core/web/jsonld/CreativeWorkTrait.php - About 1 day to fix

      File OrganizationTrait.php has 465 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace luya\web\jsonld;

/**
      Severity: Minor
      Found in core/web/jsonld/OrganizationTrait.php - About 7 hrs to fix

        File PersonTrait.php has 458 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

namespace luya\web\jsonld;

use luya\helpers\ObjectHelper;
        Severity: Minor
        Found in core/web/jsonld/PersonTrait.php - About 7 hrs to fix

          Function generateRules has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
          Open

              public function generateRules($table)
    {
        $types = [];
        $lengths = [];
        foreach ($table->columns as $column) {
          Severity: Minor
          Found in core/console/commands/BaseCrudController.php - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function textToSpeech has 106 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              $.textToSpeech = function(options) {
        var settings = $.extend(
            {
                text: '',
                playEvent: 'textToSpeech:play',
          Severity: Major
          Found in core/resources/texttospeech/texttospeech.src.js - About 4 hrs to fix

            File PlaceTrait.php has 335 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php

namespace luya\web\jsonld;

/**
            Severity: Minor
            Found in core/web/jsonld/PlaceTrait.php - About 4 hrs to fix

              Function getInternalResolverArray has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function getInternalResolverArray()
    {
        if ($this->_resolved === null) {
            $requestPathInfo = $this->trailingPathInfo();
            $newRegex = $this->buildRegexPattern();
              Severity: Minor
              Found in core/web/CompositionResolver.php - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function actionInit has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function actionInit()
    {
        // username
        $username = $this->getConfig(self::CONFIG_VAR_USERNAME);
        if (!$username) {
              Severity: Minor
              Found in dev/RepoController.php - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method generateRules has 80 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function generateRules($table)
    {
        $types = [];
        $lengths = [];
        foreach ($table->columns as $column) {
              Severity: Major
              Found in core/console/commands/BaseCrudController.php - About 3 hrs to fix

                Function actionIndex has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function actionIndex()
    {
        // opcache reset should run in web context, but might be helpfull as well.
        if (function_exists('opcache_reset')) {
            @opcache_reset();
                Severity: Minor
                Found in core/console/commands/HealthController.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function buildTraceItem has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function buildTraceItem(array $item)
    {
        $file = $item['file'] ?? null;
        $line = $item['line'] ?? null;
        $contextLine = null;
                Severity: Minor
                Found in core/traits/ErrorHandlerTrait.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File EventTrait.php has 282 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php

namespace luya\web\jsonld;

use luya\helpers\ObjectHelper;
                Severity: Minor
                Found in core/web/jsonld/EventTrait.php - About 2 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      function removeEvent(node, event, fn, opt_useCapture) {
      if (typeof node.removeEventListener == 'function') {
        node.removeEventListener(event, fn, opt_useCapture || false);
      }
      else if (typeof node.detatchEvent == 'function') {
                  Severity: Major
                  Found in core/resources/lazyload/intersectionObserver.polyfill.src.js and 1 other location - About 2 hrs to fix
                  core/resources/lazyload/intersectionObserver.polyfill.src.js on lines 1359..1366

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 84.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      function addEvent(node, event, fn, opt_useCapture) {
      if (typeof node.addEventListener == 'function') {
        node.addEventListener(event, fn, opt_useCapture || false);
      }
      else if (typeof node.attachEvent == 'function') {
                  Severity: Major
                  Found in core/resources/lazyload/intersectionObserver.polyfill.src.js and 1 other location - About 2 hrs to fix
                  core/resources/lazyload/intersectionObserver.polyfill.src.js on lines 1377..1384

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 84.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function selectModule has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function selectModule(array $options = [])
    {
        $modules = [];
        foreach (Yii::$app->getModules() as $id => $object) {
            if (!$object instanceof \luya\base\Module) {
                  Severity: Minor
                  Found in core/console/Command.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method getExceptionArray has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getExceptionArray($exception)
    {
        $_message = 'Uknonwn exception object, not instance of \Exception.';
        $_file = 'unknown';
        $_line = 0;
                  Severity: Major
                  Found in core/traits/ErrorHandlerTrait.php - About 2 hrs to fix

                    Composition has 22 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class Composition extends Component implements \ArrayAccess
{
    public const VAR_LANG_SHORT_CODE = 'langShortCode';

    /**
                    Severity: Minor
                    Found in core/web/Composition.php - About 2 hrs to fix

                      JsonLd has 22 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class JsonLd extends BaseObject
{
    /**
     * Register new Article.
     *
                      Severity: Minor
                      Found in core/web/JsonLd.php - About 2 hrs to fix

                        Method actionInit has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function actionInit()
    {
        // username
        $username = $this->getConfig(self::CONFIG_VAR_USERNAME);
        if (!$username) {
                        Severity: Major
                        Found in dev/RepoController.php - About 2 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language