zest/base.resolver

View on GitHub

Showing 13 of 13 total issues

Function exports has 185 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function () {
    var configurationsMap = {}, startups = [], /**
     * A configurations manager manages the lifecycle of one configuration array for dependency injection in
     * resolver.
     * @namespace module:base-resolver/configurations~ConfigurationManager
Severity: Major
Found in lib/resolver/configurations.js - About 7 hrs to fix

    Function setup has 167 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            setup: function (configArray, baseDir) {
                // create a clone of the config array for use. Since, the configuration is not read but required. There
                // will otherwise be only one global copy which anyone could change
                configArray = utils.clone(configArray);
                return Q.all(
    Severity: Major
    Found in lib/resolver/configurations.js - About 6 hrs to fix

      Function resolverFactory has 94 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var resolverFactory = function (configPathOrArray, basePath) {
          // array of configurations
          var args = [
                  configPathOrArray,
                  basePath
      Severity: Major
      Found in lib/index.js - About 3 hrs to fix

        Function resolveExpression has 82 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.resolveExpression = function (expression, resolverFunction) {
            var optional, expressions, deferred, promise, retVal, getNextPromise;
            if (typeof expression !== 'string') {
                if (typeof expression !== 'object') {
                    // if the expression is not a string or an object, we resolve it with its value
        Severity: Major
        Found in lib/resolver/utils.js - About 3 hrs to fix

          Function exports has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function (configurations, unloader) {
              // components map is used to cache components.
              var componentsMap = {}, /**
               * This function resolves an expression and returns a promise that resolves to the corresponding component
               * @param {string} dependencyExpression - the expression to resolve
          Severity: Minor
          Found in lib/resolver/resolution-provider.js - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has 59 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function (configurations, unloader) {
              // components map is used to cache components.
              var componentsMap = {}, /**
               * This function resolves an expression and returns a promise that resolves to the corresponding component
               * @param {string} dependencyExpression - the expression to resolve
          Severity: Major
          Found in lib/resolver/resolution-provider.js - About 2 hrs to fix

            Function resolve has 49 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                resolve = function (dependencyExpression) {
                    logger.debug('trying to resolve:', dependencyExpression);
                    return utils.resolveExpression(
                        dependencyExpression, function (componentName, params, cacheKey, immediate) {
                            logger.debug('\tparsing  :', componentName);
            Severity: Minor
            Found in lib/resolver/resolution-provider.js - About 1 hr to fix

              Function resolverFactory has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

              var resolverFactory = function (configPathOrArray, basePath) {
                  // array of configurations
                  var args = [
                          configPathOrArray,
                          basePath
              Severity: Minor
              Found in lib/index.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                              if (config.native) {
                                                  // if the node module is native, just return it from the factory function
                                                  logger.debug('\tfactory is a native component.');
                                                  componentObject = config.factory;
                                                  config.factory = [
              Severity: Major
              Found in lib/resolver/configurations.js and 1 other location - About 1 hr to fix
              lib/resolver/configurations.js on lines 162..176

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 68.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                              } else if (!utils.isInjectorArray(config.factory)) {
                                                  // if component returns an object, return it from the factory function
                                                  logger.debug('\tfactory is an object.');
                                                  componentObject = config.factory;
                                                  config.factory = [
              Severity: Major
              Found in lib/resolver/configurations.js and 1 other location - About 1 hr to fix
              lib/resolver/configurations.js on lines 144..176

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 68.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function exports has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function () {
                  var unloaders = [];
                  /**
                   * Unloader is returned by {@link module:base-resolver/unloader}
                   * @namespace module:base-resolver/unloader~Unloader
              Severity: Minor
              Found in lib/resolver/unloader.js - About 1 hr to fix

                Avoid too many return statements within this function.
                Open

                                                return 'component-' + parseInt(Math.random() * 9999999999, 10);
                Severity: Major
                Found in lib/resolver/configurations.js - About 30 mins to fix

                  Function isInjectorArray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.isInjectorArray = function (obj) {
                      return (Object.prototype.toString.call(obj) === '[object Array]') && (typeof obj[obj.length - 1] === 'function') &&
                          (function () {
                              var i, j;
                              for (i = 0, j = obj.length - 1; i < j; i = i + 1) {
                  Severity: Minor
                  Found in lib/resolver/utils.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language