zest/base.resolver

View on GitHub
lib/resolver/configurations.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has 185 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function () {
    var configurationsMap = {}, startups = [], /**
     * A configurations manager manages the lifecycle of one configuration array for dependency injection in
     * resolver.
     * @namespace module:base-resolver/configurations~ConfigurationManager
Severity: Major
Found in lib/resolver/configurations.js - About 7 hrs to fix

    Function setup has 167 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            setup: function (configArray, baseDir) {
                // create a clone of the config array for use. Since, the configuration is not read but required. There
                // will otherwise be only one global copy which anyone could change
                configArray = utils.clone(configArray);
                return Q.all(
    Severity: Major
    Found in lib/resolver/configurations.js - About 6 hrs to fix

      Avoid too many return statements within this function.
      Open

                                      return 'component-' + parseInt(Math.random() * 9999999999, 10);
      Severity: Major
      Found in lib/resolver/configurations.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                        if (config.native) {
                                            // if the node module is native, just return it from the factory function
                                            logger.debug('\tfactory is a native component.');
                                            componentObject = config.factory;
                                            config.factory = [
        Severity: Major
        Found in lib/resolver/configurations.js and 1 other location - About 1 hr to fix
        lib/resolver/configurations.js on lines 162..176

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                        } else if (!utils.isInjectorArray(config.factory)) {
                                            // if component returns an object, return it from the factory function
                                            logger.debug('\tfactory is an object.');
                                            componentObject = config.factory;
                                            config.factory = [
        Severity: Major
        Found in lib/resolver/configurations.js and 1 other location - About 1 hr to fix
        lib/resolver/configurations.js on lines 144..176

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status