Sign upLogin

zhdk/madek

View on GitHub
Star
app/controllers/application_controller.rb

Summary

Maintainability
F
3 days
Test Coverage

Consider simplifying this complex logical expression.
Open

    elsif request.format.to_sym == :json or
          (request[:controller] == "media_resources" and request[:action] == "image") or 
          (request[:controller] == "media_resources" and request[:action] == "show") or
          (request[:controller] == "media_resources" and request[:action] == "index") or
          (request[:controller] == "media_resources" and request[:action] == "browse") or
Severity: Critical
Found in app/controllers/application_controller.rb - About 1 day to fix

    Method login_from_session has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
    Open

      def login_from_session
    user = nil

    if session[:user_id]
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class ApplicationController has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class ApplicationController < ActionController::Base
  #FE# before_filter { headers['Access-Control-Allow-Origin'] = '*' }

  ################
  # Error Classes like <http://www.ruby-doc.org/core-2.1.2/Exception.html>
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 2 hrs to fix

      Method login_from_session has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def login_from_session
    user = nil

    if session[:user_id]
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 2 hrs to fix

        Method root has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def root
    if logged_in? and not current_user.is_guest?
      if @already_redirected
        # do nothing
      elsif session[:return_to]
        Severity: Minor
        Found in app/controllers/application_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          def error_application    # handles 'Error'
    msg = "Entschuldigung, ein allgemeiner Fehler ist aufgetreten." 
    respond_to do |format|
      format.html { flash[:error] = msg ; redirect_back_or_root }
      format.json { render :json => {error: msg}, status: 500}
        Severity: Minor
        Found in app/controllers/application_controller.rb and 3 other locations - About 20 mins to fix
        app/controllers/application_controller.rb on lines 154..158
        app/controllers/application_controller.rb on lines 162..166
        app/controllers/application_controller.rb on lines 170..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          def error_unprocessable_entity # handles 'UnprocessableEntityError'
    msg = "Unprocessable entity error message." 
    respond_to do |format|
      format.html { flash[:error] = msg ; redirect_back_or_root }
      format.json { render :json => {error: msg}, status: :unprocessable_entity}
        Severity: Minor
        Found in app/controllers/application_controller.rb and 3 other locations - About 20 mins to fix
        app/controllers/application_controller.rb on lines 137..141
        app/controllers/application_controller.rb on lines 154..158
        app/controllers/application_controller.rb on lines 170..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          def error_not_allowed # handles 'NotAllowedError'
    msg = "Not allowed error message." 
    respond_to do |format|
      format.html { flash[:error] = msg ; redirect_back_or_root }
      format.json { render :json => {error: msg}, status: :not_allowed}
        Severity: Minor
        Found in app/controllers/application_controller.rb and 3 other locations - About 20 mins to fix
        app/controllers/application_controller.rb on lines 137..141
        app/controllers/application_controller.rb on lines 154..158
        app/controllers/application_controller.rb on lines 162..166

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          def error_user_forbidden # handles 'UserForbiddenError'
    msg = "Sie haben nicht die notwendige Zugriffsberechtigung." 
    respond_to do |format|
      format.html { flash[:error] = msg ; redirect_back_or_root }
      format.json { render :json => {error: msg}, status: :not_authorized}
        Severity: Minor
        Found in app/controllers/application_controller.rb and 3 other locations - About 20 mins to fix
        app/controllers/application_controller.rb on lines 137..141
        app/controllers/application_controller.rb on lines 162..166
        app/controllers/application_controller.rb on lines 170..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status