Sign upLogin

zhdk/madek

View on GitHub
Star
app/controllers/concerns/custom_urls.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method redirect_to_primary_url has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def redirect_to_primary_url
      if UUID_MATCHER.match params[:id] # id is a UUID; redirect if there is a custom primary url
        if (@media_resource=MediaResource.find(params[:id])) and (primary_custom_url= @media_resource.primary_custom_url)
          redirect_to_primary_custom_url(primary_custom_url)
        end
Severity: Minor
Found in app/controllers/concerns/custom_urls.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

            redirect_to_primary_custom_url(custom_url) unless (self.class == MediaSetsController)
Severity: Major
Found in app/controllers/concerns/custom_urls.rb - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                redirect_to_primary_custom_url(custom_url) unless (self.class == MediaEntriesController)
    Severity: Major
    Found in app/controllers/concerns/custom_urls.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  redirect_to_primary_custom_url(custom_url) unless (self.class == FilterSetsController)
      Severity: Major
      Found in app/controllers/concerns/custom_urls.rb - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status