Sign upLogin

zhdk/madek

View on GitHub
Star
app/controllers/custom_urls_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method create has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    begin
      @media_resource= MediaResource.find params[:id]
      raise UserForbiddenError unless create_url_authorized?
      if not current_user.act_as_uberadmin and
Severity: Minor
Found in app/controllers/custom_urls_controller.rb - About 1 hr to fix

    Method set_primary_url has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def set_primary_url
    begin
      ActiveRecord::Base.transaction do
        @media_resource= MediaResource.find params[:id]
        raise UserForbiddenError unless current_user.authorized?(:manage,@media_resource)
    Severity: Minor
    Found in app/controllers/custom_urls_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    begin
      @media_resource= MediaResource.find params[:id]
      raise UserForbiddenError unless create_url_authorized?
      if not current_user.act_as_uberadmin and
    Severity: Minor
    Found in app/controllers/custom_urls_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method index has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def index
    @media_resource= MediaResource.find params[:id]
    raise UserUnauthorizedError unless current_user.login.present? || current_user.authorized?(:view, @media_resource)
    begin
      raise "Forbidden" unless current_user.authorized?(:view, @media_resource)
    Severity: Minor
    Found in app/controllers/custom_urls_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status