Sign upLogin

zhdk/madek

View on GitHub
Star
app/controllers/import_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method destroy has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def destroy
     respond_to do |format|
       
        format.html do
          # we are canceling the full import, but not deleting
Severity: Minor
Found in app/controllers/import_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method destroy has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def destroy
     respond_to do |format|
       
        format.html do
          # we are canceling the full import, but not deleting
Severity: Minor
Found in app/controllers/import_controller.rb - About 1 hr to fix

    Method dropbox_import has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def dropbox_import
    begin
      current_user.dropbox_files.each do |f|
        ExceptionHelper.log_and_reraise do
          ActiveRecord::Base.transaction do
    Severity: Minor
    Found in app/controllers/import_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status