Sign upLogin

zhdk/madek

View on GitHub
Star
app/controllers/responsibilities_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method transfer has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def transfer

    @all_media_resources= if not params[:media_resource_id].blank? # the case where we edit one 
                            MediaResource.where(id: params[:media_resource_id])
                          elsif not params[:collection_id].blank?
Severity: Minor
Found in app/controllers/responsibilities_controller.rb - About 1 hr to fix

    Method transfer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def transfer

    @all_media_resources= if not params[:media_resource_id].blank? # the case where we edit one 
                            MediaResource.where(id: params[:media_resource_id])
                          elsif not params[:collection_id].blank?
    Severity: Minor
    Found in app/controllers/responsibilities_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status