Sign upLogin

zhdk/madek

View on GitHub
Star
app/helpers/json/media_resource_helper.rb

Summary

Maintainability
F
5 days
Test Coverage

Method hash_for_media_resource has a Cognitive Complexity of 135 (exceeds 5 allowed). Consider refactoring.
Open

    def hash_for_media_resource(media_resource, with = nil)
      h = {
        id: media_resource.id,
        created_at: media_resource.created_at.iso8601,
        updated_at: media_resource.updated_at.iso8601,
Severity: Minor
Found in app/helpers/json/media_resource_helper.rb - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hash_for_filter has 171 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def hash_for_filter(media_resources, filter_types = [:media_files, :permissions, :meta_data, :media_resource_type])
      r = []

      if filter_types.include? :media_resource_type
        r << { :filter_type => "media_resources",
Severity: Major
Found in app/helpers/json/media_resource_helper.rb - About 6 hrs to fix

    Method hash_for_media_resource has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def hash_for_media_resource(media_resource, with = nil)
      h = {
        id: media_resource.id,
        created_at: media_resource.created_at.iso8601,
        updated_at: media_resource.updated_at.iso8601,
    Severity: Major
    Found in app/helpers/json/media_resource_helper.rb - About 4 hrs to fix

      File media_resource_helper.rb has 333 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      module Json
  module MediaResourceHelper

    def hash_for_media_resource(media_resource, with = nil)
      h = {
      Severity: Minor
      Found in app/helpers/json/media_resource_helper.rb - About 4 hrs to fix

        Method hash_for_filter has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            def hash_for_filter(media_resources, filter_types = [:media_files, :permissions, :meta_data, :media_resource_type])
      r = []

      if filter_types.include? :media_resource_type
        r << { :filter_type => "media_resources",
        Severity: Minor
        Found in app/helpers/json/media_resource_helper.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method hash_for_media_resources_with_pagination has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            def hash_for_media_resources_with_pagination(media_resources, pagination, with = nil, type_totals = false)
      page = (pagination.is_a?(Hash) ? pagination[:page] : nil) || 1
      per_page = [((pagination.is_a?(Hash) ? pagination[:per_page] : nil) || PER_PAGE.first).to_i.abs, PER_PAGE.last].min
      paginated_media_resources = media_resources.page(page).per(per_page)
        Severity: Minor
        Found in app/helpers/json/media_resource_helper.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method hash_for_media_resources_with_pagination has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def hash_for_media_resources_with_pagination(media_resources, pagination, with = nil, type_totals = false)
      page = (pagination.is_a?(Hash) ? pagination[:page] : nil) || 1
      per_page = [((pagination.is_a?(Hash) ? pagination[:per_page] : nil) || PER_PAGE.first).to_i.abs, PER_PAGE.last].min
      paginated_media_resources = media_resources.page(page).per(per_page)
        Severity: Minor
        Found in app/helpers/json/media_resource_helper.rb - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                          case with[:children][:type]
                  when "media_entry"
                    media_resources = media_resources.media_entries
                  when "media_set"
                    media_resources = media_resources.media_sets
          Severity: Major
          Found in app/helpers/json/media_resource_helper.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                            case with[:children][:type]
                  when "media_entry"
                    media_resources = media_resources.media_entries
                  when "media_set"
                    media_resources = media_resources.media_sets
            Severity: Major
            Found in app/helpers/json/media_resource_helper.rb - About 45 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              case with[:children][:type]
                  when "media_entry"
                    media_resources = media_resources.media_entries
                  when "media_set"
                    media_resources = media_resources.media_sets
              Severity: Minor
              Found in app/helpers/json/media_resource_helper.rb and 1 other location - About 25 mins to fix
              app/helpers/json/media_resource_helper.rb on lines 115..121

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 30.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              case with[:children][:type]
                  when "media_entry"
                    media_resources = media_resources.media_entries
                  when "media_set"
                    media_resources = media_resources.media_sets
              Severity: Minor
              Found in app/helpers/json/media_resource_helper.rb and 1 other location - About 25 mins to fix
              app/helpers/json/media_resource_helper.rb on lines 96..102

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 30.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status