Sign upLogin

zhdk/madek

View on GitHub
Star
app/models/media_entry.rb

Summary

Maintainability
C
1 day
Test Coverage

Method to_tms has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

  def to_tms(xml, io_interface)
    xml.snapshot do
      #old# meta_data.each do |meta_datum|
      meta_data.for_io_interface(io_interface).each do |meta_datum|
        key_map = meta_datum.meta_key.key_map_for(io_interface)
Severity: Minor
Found in app/models/media_entry.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_tms has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def to_tms(xml, io_interface)
    xml.snapshot do
      #old# meta_data.each do |meta_datum|
      meta_data.for_io_interface(io_interface).each do |meta_datum|
        key_map = meta_datum.meta_key.key_map_for(io_interface)
Severity: Major
Found in app/models/media_entry.rb - About 2 hrs to fix

    Method original_exifcreated_duplicates has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.original_exifcreated_duplicates

    seen_timestamps = Set.new
    duplicate_ids = Set.new
    Severity: Minor
    Found in app/models/media_entry.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method original_filename_duplicates has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.original_filename_duplicates

    files_md5 = Set.new
    duplicate_ids = Set.new
    Severity: Minor
    Found in app/models/media_entry.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method original_md5file_duplicates has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.original_md5file_duplicates

    files_md5 = Set.new
    duplicate_ids = Set.new
    Severity: Minor
    Found in app/models/media_entry.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status