Sign upLogin

zhdk/madek

View on GitHub
Star
app/models/media_file_modules/previews.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method create_jpeg_previews_for_file has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def create_jpeg_previews_for_file file 
      raise "Input file doesn't exist!" unless File.exist?(file)
      THUMBNAILS.each do |thumb_size,value|
        tmparr = thumbnail_storage_location
        tmparr += "_#{thumb_size.to_s}"
Severity: Minor
Found in app/models/media_file_modules/previews.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method thumb_placeholder has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def thumb_placeholder(size)
      dir = File.join(Rails.root, "app/assets/images/thumbnails")
      @@placeholders ||= Dir.glob(File.join(dir, "*"))
      extension = File.extname(filename).downcase
      if extension.blank?
Severity: Minor
Found in app/models/media_file_modules/previews.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method thumb_base64 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def thumb_base64(size = :small)
      size = size.to_sym

      preview = case content_type
                when /video/ then
Severity: Minor
Found in app/models/media_file_modules/previews.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status