Sign upLogin

zhenkyle/shadowsocks_ruby

View on GitHub
Star
lib/shadowsocks_ruby/protocols/obfs/http_simple.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method tcp_receive_from_localbackend_first_packet has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

      def tcp_receive_from_localbackend_first_packet n
        data = async_recv 10
        if (data =~ /^GET|^POST/) == nil
          if @params[:compatible]
            @buffer << data << async_recv(n - data.length)
Severity: Minor
Found in lib/shadowsocks_ruby/protocols/obfs/http_simple.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method tcp_send_to_remoteserver_first_packet has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def tcp_send_to_remoteserver_first_packet data
        if data.length > 30 + 64
          headlen = 30 + Random.rand(64 + 1)
        else
          headlen = data.length
Severity: Minor
Found in lib/shadowsocks_ruby/protocols/obfs/http_simple.rb - About 1 hr to fix

    Method tcp_receive_from_localbackend_first_packet has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def tcp_receive_from_localbackend_first_packet n
        data = async_recv 10
        if (data =~ /^GET|^POST/) == nil
          if @params[:compatible]
            @buffer << data << async_recv(n - data.length)
    Severity: Minor
    Found in lib/shadowsocks_ruby/protocols/obfs/http_simple.rb - About 1 hr to fix

      Method tcp_send_to_remoteserver_first_packet has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def tcp_send_to_remoteserver_first_packet data
        if data.length > 30 + 64
          headlen = 30 + Random.rand(64 + 1)
        else
          headlen = data.length
      Severity: Minor
      Found in lib/shadowsocks_ruby/protocols/obfs/http_simple.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status