Sign upLogin

zhenkyle/shadowsocks_ruby

View on GitHub
Star
lib/shadowsocks_ruby/protocols/obfs/tls_ticket.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File tls_ticket.rb has 262 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'lrucache'

module ShadowsocksRuby
  module Protocols
    # TLS 1.2 Obfuscation Protocol
Severity: Minor
Found in lib/shadowsocks_ruby/protocols/obfs/tls_ticket.rb - About 2 hrs to fix

    Method recv_client_hello has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def recv_client_hello
        data = async_recv 3
        if data != [CTYPE_Handshake, *VERSION_TLS_1_0].pack("C3")
          if @params[:compatible]
            @buffer = data
    Severity: Minor
    Found in lib/shadowsocks_ruby/protocols/obfs/tls_ticket.rb - About 1 hr to fix

      Method recv_client_hello has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

            def recv_client_hello
        data = async_recv 3
        if data != [CTYPE_Handshake, *VERSION_TLS_1_0].pack("C3")
          if @params[:compatible]
            @buffer = data
      Severity: Minor
      Found in lib/shadowsocks_ruby/protocols/obfs/tls_ticket.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method send_client_hello has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def send_client_hello
        client_hello = ""
        
        client_hello << [*VERSION_TLS_1_2].pack("C2") # ProtocolVersion
        client_hello << get_random # Random len 32
      Severity: Minor
      Found in lib/shadowsocks_ruby/protocols/obfs/tls_ticket.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status