Showing 139 of 191 total issues
Function get_mcl_str
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def get_mcl_str(bundle_level, ec_levels, all_, concurrent, install_disruptive):
Function find_port
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def find_port(cmd_ctx, client, cpc_name, adapter_name, port_name):
Function cmd_hba_update
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def cmd_hba_update(cmd_ctx, cpc_name, partition_name, hba_name, options):
Function lpar_load
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def lpar_load(cmd_ctx, cpc, lpar, load_address, **options):
Function cmd_port_update
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def cmd_port_update(cmd_ctx, cpc_name, adapter_name, port_name, options):
Function port_update
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def port_update(cmd_ctx, cpc, adapter, port, **options):
Function find_nic
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def find_nic(cmd_ctx, client, cpc_name, partition_name, nic_name):
Function cmd_metrics_nic
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def cmd_metrics_nic(cmd_ctx, cpc_name, partition_name, nic_name, options):
Function nic_update
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def nic_update(cmd_ctx, cpc, partition, nic, **options):
Function cmd_nic_update
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def cmd_nic_update(cmd_ctx, cpc_name, partition_name, nic_name, options):
Function find_vfunction
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def find_vfunction(cmd_ctx, client, cpc_name, partition_name, vfunction_name):
Function find_hba
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def find_hba(cmd_ctx, client, cpc_name, partition_name, hba_name):
Function hba_update
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def hba_update(cmd_ctx, cpc, partition, hba, **options):
Function metrics_nic
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def metrics_nic(cmd_ctx, cpc, partition, nic, **options):
Function cmd_vfunction_update
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def cmd_vfunction_update(cmd_ctx, cpc_name, partition_name, vfunction_name,
Function print_resources_as_json
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def print_resources_as_json(
Function vfunction_update
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def vfunction_update(cmd_ctx, cpc, partition, vfunction, **options):
Function cmd_lpar_load
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def cmd_lpar_load(cmd_ctx, cpc_name, lpar_name, load_address, options):
Function parse_ec_levels
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def parse_ec_levels(cmd_ctx, option_name, ec_levels):
"""
Parse a list of EC levels specified in the command line as a list in
YAML Flow Collection style, where the list items are strings of the form
'EC.MCL' where EC is the EC number of the EC stream, and MCL is the MCL
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function cmd_cpc_upgrade
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def cmd_cpc_upgrade(cmd_ctx, cpc_name, options):
# pylint: disable=missing-function-docstring
client = zhmcclient.Client(cmd_ctx.session)
cpc = find_cpc(cmd_ctx, client, cpc_name)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"