File _cmd_nic.py has 457 lines of code (exceeds 250 allowed). Consider refactoring. Open
# Copyright 2016,2019 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License atFunction backing_uri has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
def backing_uri(cmd_ctx, cpc, org_options, required=False):
"""
Determine the backing adapter port or vswitch to be used from the
--adapter, --port, and --virtual-switch options, and return a dict with the
correct property for the URI of the backing port or vswitch to be used for- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Cyclomatic complexity is too high in function cmd_nic_show. (19) Open
def cmd_nic_show(cmd_ctx, cpc_name, partition_name, nic_name):
# pylint: disable=missing-function-docstring
client = zhmcclient.Client(cmd_ctx.session)
nic = find_nic(cmd_ctx, client, cpc_name, partition_name, nic_name)- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
| Construct | Effect on CC | Reasoning |
|---|---|---|
| if | +1 | An if statement is a single decision. |
| elif | +1 | The elif statement adds another decision. |
| else | +0 | The else statement does not cause a new decision. The decision is at the if. |
| for | +1 | There is a decision at the start of the loop. |
| while | +1 | There is a decision at the while statement. |
| except | +1 | Each except branch adds a new conditional path of execution. |
| finally | +0 | The finally block is unconditionally executed. |
| with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
| assert | +1 | The assert statement internally roughly equals a conditional statement. |
| Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
| Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in function backing_uri. (17) Open
def backing_uri(cmd_ctx, cpc, org_options, required=False):
"""
Determine the backing adapter port or vswitch to be used from the
--adapter, --port, and --virtual-switch options, and return a dict with the
correct property for the URI of the backing port or vswitch to be used for- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
| Construct | Effect on CC | Reasoning |
|---|---|---|
| if | +1 | An if statement is a single decision. |
| elif | +1 | The elif statement adds another decision. |
| else | +0 | The else statement does not cause a new decision. The decision is at the if. |
| for | +1 | There is a decision at the start of the loop. |
| while | +1 | There is a decision at the while statement. |
| except | +1 | Each except branch adds a new conditional path of execution. |
| finally | +0 | The finally block is unconditionally executed. |
| with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
| assert | +1 | The assert statement internally roughly equals a conditional statement. |
| Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
| Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Function set_vlan_id_type has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def set_vlan_id_type(cmd_ctx, properties, org_options):
"""
Set the 'vlan-id' and 'vlan-type' properties from the options.
"""
vlan_id = org_options['vlan-id']- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function cmd_nic_update has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def cmd_nic_update(cmd_ctx, cpc_name, partition_name, nic_name, options):Function find_nic has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def find_nic(cmd_ctx, client, cpc_name, partition_name, nic_name):Function nic_update has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def nic_update(cmd_ctx, cpc, partition, nic, **options):Avoid too many return statements within this function. Open
return {'virtual-switch-uri': vswitch.uri}Function cmd_nic_update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def cmd_nic_update(cmd_ctx, cpc_name, partition_name, nic_name, options):
# pylint: disable=missing-function-docstring
client = zhmcclient.Client(cmd_ctx.session)
nic = find_nic(cmd_ctx, client, cpc_name, partition_name, nic_name)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function cmd_nic_list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def cmd_nic_list(cmd_ctx, cpc_name, partition_name, options):
# pylint: disable=missing-function-docstring
client = zhmcclient.Client(cmd_ctx.session)
partition = find_partition(cmd_ctx, client, cpc_name, partition_name)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"