Sign upLogin

zhuhaow/NEKit

View on GitHub
Star

Showing 607 of 607 total issues

File UInt128.swift has 502 lines of code (exceeds 250 allowed). Consider refactoring.
Open

public enum UInt128Errors : Error {
    /// Input cannot be converted to a UInt128 value.
    case invalidString
}
Severity: Major
Found in src/Utils/UInt128.swift - About 1 day to fix

    File DNSMessage.swift has 321 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import Foundation
import CocoaLumberjackSwift

open class DNSMessage {
    //    var sourceAddress: IPv4Address?
    Severity: Minor
    Found in src/IPStack/DNS/DNSMessage.swift - About 3 hrs to fix

      File ProtocolObfuscater.swift has 304 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import Foundation

extension ShadowsocksAdapter {
    public struct ProtocolObfuscater {
        public class Factory {
      Severity: Minor
      Found in src/Socket/AdapterSocket/Shadowsocks/ProtocolObfuscater.swift - About 3 hrs to fix

        Function didRead has 82 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            override public func didRead(data: Data, from: RawTCPSocketProtocol) {
        super.didRead(data: data, from: from)

        switch readStatus {
        case .forwarding:
        Severity: Major
        Found in src/Socket/ProxySocket/SOCKS5ProxySocket.swift - About 3 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public convenience init(withRangeString rep: String) throws {
        let info = rep.components(separatedBy: "+")
        guard info.count == 2 else {
            throw IPRangeError.invalidRangeFormat
        }
          Severity: Major
          Found in src/Utils/IPRange.swift and 1 other location - About 3 hrs to fix
          src/Utils/IPRange.swift on lines 54..79

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 197.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public convenience init(withCIDRString rep: String) throws {
        let info = rep.components(separatedBy: "/")
        guard info.count == 2 else {
            throw IPRangeError.invalidCIDRFormat
        }
          Severity: Major
          Found in src/Utils/IPRange.swift and 1 other location - About 3 hrs to fix
          src/Utils/IPRange.swift on lines 81..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 197.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function multipliedFullWidth has 75 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public func multipliedFullWidth(by other: UInt128) -> (high: UInt128, low: UInt128.Magnitude) {
        // Bit mask that facilitates masking the lower 32 bits of a 64 bit UInt.
        let lower32 = UInt64(UInt32.max)
        
        // Decompose lhs into an array of 4, 32 significant bit UInt64s.
          Severity: Major
          Found in src/Utils/UInt128.swift - About 3 hrs to fix

            Function checkReadData has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
            Open

                fileprivate func checkReadData() {
        if pendingReadData.count > 0 {
            queueCall {
                guard self.reading else {
                    // no queued read request
            Severity: Minor
            Found in src/RawSocket/TUNTCPSocket.swift - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function spec has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
            Open

                override func spec() {
        let cidrWrongSamples = [
            ("127.0.0.132", IPRangeError.invalidCIDRFormat),
            ("13.1242.1241.1/3", IPRangeError.invalidCIDRFormat),
            ("123.122.33.21/35", IPRangeError.invalidMask),
            Severity: Minor
            Found in test/Utils/IPRangeSpec.swift - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function spec has 66 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                override func spec() {
        let cidrWrongSamples = [
            ("127.0.0.132", IPRangeError.invalidCIDRFormat),
            ("13.1242.1241.1/3", IPRangeError.invalidCIDRFormat),
            ("123.122.33.21/35", IPRangeError.invalidMask),
            Severity: Major
            Found in test/Utils/IPRangeSpec.swift - About 2 hrs to fix

              Function parseShadowsocksAdapterFactory has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
              Open

                  static func parseShadowsocksAdapterFactory(_ config: Yaml) throws -> ShadowsocksAdapterFactory {
        guard let host = config["host"].string else {
            throw ConfigurationParserError.adapterParsingError(errorInfo: "Host (host) is required.")
        }
              Severity: Minor
              Found in src/Config/AdapterFactoryParser.swift - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function parseShadowsocksAdapterFactory has 60 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  static func parseShadowsocksAdapterFactory(_ config: Yaml) throws -> ShadowsocksAdapterFactory {
        guard let host = config["host"].string else {
            throw ConfigurationParserError.adapterParsingError(errorInfo: "Host (host) is required.")
        }
              Severity: Major
              Found in src/Config/AdapterFactoryParser.swift - About 2 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public func addingReportingOverflow(_ rhs: UInt128) -> (partialValue: UInt128, overflow: Bool) {
        var resultOverflow = false
        let (lowerBits, lowerOverflow) = self.value.lowerBits.addingReportingOverflow(rhs.value.lowerBits)
        var (upperBits, upperOverflow) = self.value.upperBits.addingReportingOverflow(rhs.value.upperBits)
                Severity: Major
                Found in src/Utils/UInt128.swift and 1 other location - About 2 hrs to fix
                src/Utils/UInt128.swift on lines 212..224

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 146.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                import Foundation
import Sodium

open class SodiumStreamCrypto: StreamCryptoProtocol {
    public enum Alogrithm {
                Severity: Major
                Found in src/Crypto/SodiumStreamCrypto.swift and 1 other location - About 2 hrs to fix
                src/Crypto/SodiumStreamCrypto.swift on lines 1..69

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 146.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public func subtractingReportingOverflow(_ rhs: UInt128) -> (partialValue: UInt128, overflow: Bool) {
        var resultOverflow = false
        let (lowerBits, lowerOverflow) = self.value.lowerBits.subtractingReportingOverflow(rhs.value.lowerBits)
        var (upperBits, upperOverflow) = self.value.upperBits.subtractingReportingOverflow(rhs.value.upperBits)
                Severity: Major
                Found in src/Utils/UInt128.swift and 1 other location - About 2 hrs to fix
                src/Utils/UInt128.swift on lines 198..210

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 146.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function handleStatus0 has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            private func handleStatus0() {
                status = 1

                var outData = Data()
                outData.append(contentsOf: [0x03, 0x03])
                Severity: Major
                Found in src/Socket/AdapterSocket/Shadowsocks/ProtocolObfuscater.swift - About 2 hrs to fix

                  Function didRead has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      override public func didRead(data: Data, from: RawTCPSocketProtocol) {
        super.didRead(data: data, from: from)

        switch readStatus {
        case .forwarding:
                  Severity: Minor
                  Found in src/Socket/ProxySocket/SOCKS5ProxySocket.swift - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function input has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      func input(_ data: Data) throws -> Result {
        switch nextAction {
        case .readHeader:
            let header: HTTPHeader
            do {
                  Severity: Minor
                  Found in src/Utils/HTTPStreamScanner.swift - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  import Foundation

public class SOCKS5ProxySocket: ProxySocket {
    enum SOCKS5ProxyReadStatus: CustomStringConvertible {
        case invalid,
                  Severity: Major
                  Found in src/Socket/ProxySocket/SOCKS5ProxySocket.swift and 1 other location - About 1 hr to fix
                  src/Socket/ProxySocket/SOCKS5ProxySocket.swift on lines 1..244

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 119.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function didRead has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public override func didRead(data: Data, from socket: RawTCPSocketProtocol) {
        super.didRead(data: data, from: socket)

        switch internalStatus {
        case .readingMethodResponse:
                  Severity: Minor
                  Found in src/Socket/AdapterSocket/SOCKS5Adapter.swift - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language