Sign upLogin

zidarsk8/simple_wbd

View on GitHub
Star

Showing 12 of 20 total issues

File filters.py has 1765 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Dict containing common and featured indicator ids.

This list was fetched from wold bank data site.
featured indicators: http://data.worldbank.org/indicator?tab=featured
common indicators: http://data.worldbank.org/indicator?tab=all
Severity: Major
Found in simple_wbd/filters.py - About 4 days to fix

    File indicators.py has 343 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    """World Bank Data Indicator API helper.

This is a simple indicator API helper focused on ease of use and getting data
for use with Orange data mining software. For a more comprehensive APIs see
wbpy or wbdata packages.
    Severity: Minor
    Found in simple_wbd/indicators.py - About 4 hrs to fix

      File test_climate_dataset.py has 326 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      """Unit tests for wbd climate api."""

# pylint: disable=protected-access
# we must access protected members for testing
      Severity: Minor
      Found in tests/test_climate_dataset.py - About 3 hrs to fix

        File test_indicator_dataset.py has 281 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        """Tests for indicator dataset class."""

import tests
import simple_wbd
from simple_wbd import utils
        Severity: Minor
        Found in tests/test_indicator_dataset.py - About 2 hrs to fix

          Function _clean_string_columns has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              def _clean_string_columns(self, array, use_dates=False, use_names=False):
        """Turn first column and row into strings."""
        map_ = utils.get_alpha3_map()
        country_column_index = -1
        if "country" in self.columns and use_names:
          Severity: Minor
          Found in simple_wbd/climate.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function as_list has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              def as_list(self, time_series=False, add_metadata=False):
        """Get data as 2D list.

        This function returns data as a 2D list where rows contain country and
        all data related to that country, and columns contain indicator and
          Severity: Minor
          Found in simple_wbd/indicators.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function as_dict has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def as_dict(self):
        """Return api responses as nested dictionary.

        Resulting dict looks like
        result = {
          Severity: Minor
          Found in simple_wbd/climate.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _gather_keys has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def _gather_keys(data):
        countries = set()
        types = set()
        intervals = set()
        for country, c_dict in data.items():
          Severity: Minor
          Found in simple_wbd/climate.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function get_dataset has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def get_dataset(self, indicators, countries=None):
        """Get indicator dataset.

        Args:
            indicators (str or list[str]): A single indicator id, or a list of
          Severity: Minor
          Found in simple_wbd/indicators.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _countries_to_alpha3 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def _countries_to_alpha3(self, countries):
        """Filter out invalid countries and return a set of alpha3 codes.

        Args:
            countries (list or str): List of country codes or names, or a
          Severity: Minor
          Found in simple_wbd/indicators.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _get_level_key has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def _get_level_key(self, row, column, key_name):
        if key_name in self.rows:
            if key_name == "interval":
                return row[-2:]
            return row[self.rows.index(key_name)]
          Severity: Minor
          Found in simple_wbd/climate.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _get_responses_list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def _get_responses_list(self, response_data, time_series=False):
        """Get list data for multiple indicators."""
        headers = ["Date"] if time_series else ["Country"]
        data_map = None
          Severity: Minor
          Found in simple_wbd/indicators.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language