zilverline/sequent

View on GitHub
lib/sequent/core/persistors/replay_optimized_postgres_persistor.rb

Summary

Maintainability
C
1 day
Test Coverage

File replay_optimized_postgres_persistor.rb has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'set'
require 'active_record'
require 'csv'
require_relative './persistor'

Severity: Minor
Found in lib/sequent/core/persistors/replay_optimized_postgres_persistor.rb - About 2 hrs to fix

    Class ReplayOptimizedPostgresPersistor has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

          class ReplayOptimizedPostgresPersistor
            include Persistor
            CHUNK_SIZE = 1024
    
            attr_reader :record_store
    Severity: Minor
    Found in lib/sequent/core/persistors/replay_optimized_postgres_persistor.rb - About 2 hrs to fix

      Method commit has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def commit
                @record_store.each do |clazz, records|
                  @column_cache ||= {}
                  @column_cache[clazz.name] ||= clazz.columns.reduce({}) do |hash, column|
                    hash.merge({column.name => column})
      Severity: Minor
      Found in lib/sequent/core/persistors/replay_optimized_postgres_persistor.rb - About 1 hr to fix

        Method commit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

                def commit
                  @record_store.each do |clazz, records|
                    @column_cache ||= {}
                    @column_cache[clazz.name] ||= clazz.columns.reduce({}) do |hash, column|
                      hash.merge({column.name => column})
        Severity: Minor
        Found in lib/sequent/core/persistors/replay_optimized_postgres_persistor.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method find_records has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def find_records(record_class, where_clause)
                  where_clause = where_clause.symbolize_keys
        
                  indexed_columns = @record_index[record_class].indexed_columns
                  indexed_fields, non_indexed_fields = where_clause.partition { |field, _| indexed_columns.include? field }
        Severity: Minor
        Found in lib/sequent/core/persistors/replay_optimized_postgres_persistor.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status