Sign upLogin

zincware/MDSuite

View on GitHub
Star
mdsuite/calculators/einstein_diffusion_coefficients.py

Summary

Maintainability
B
4 hrs
Test Coverage

File einstein_diffusion_coefficients.py has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
MDSuite: A Zincwarecode package.

License
-------
Severity: Minor
Found in mdsuite/calculators/einstein_diffusion_coefficients.py - About 2 hrs to fix

    Function run_calculator has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def run_calculator(self):
        """Run analysis."""
        self._run_dependency_check()
        for species in self.args.species:
            # Here for now to avoid issues. Should be moved out when calculators become
    Severity: Minor
    Found in mdsuite/calculators/einstein_diffusion_coefficients.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __call__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __call__(
    Severity: Major
    Found in mdsuite/calculators/einstein_diffusion_coefficients.py - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status