Sign upLogin

zincware/MDSuite

View on GitHub
Star
mdsuite/transformations/transformations.py

Summary

Maintainability
C
1 day
Test Coverage

File transformations.py has 537 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
MDSuite: A Zincwarecode package.

License
-------
Severity: Major
Found in mdsuite/transformations/transformations.py - About 1 day to fix

    Function get_prop_through_transformation has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_prop_through_transformation(self, sp_name, prop):
        # todo prevent infinite recursion
        # (e.g. unwrap_pos calls wrap_pos calls unwrap_pos calls ...)
        from mdsuite.transformations.transformation_dict import (
            property_to_transformation_dict,
    Severity: Minor
    Found in mdsuite/transformations/transformations.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if not isinstance(val, collections.abc.Iterable):
                            val = [val]
                        val = tf.convert_to_tensor(val, dtype=self.dtype)
    Severity: Major
    Found in mdsuite/transformations/transformations.py - About 45 mins to fix

      Function _prepare_database_entry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def _prepare_database_entry(self, species: str, system_tensor=False):
        """
        Add or extend the dataset in which the transformation result is stored.

        Parameters
      Severity: Minor
      Found in mdsuite/transformations/transformations.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status