Sign upLogin

zkoss/zk

View on GitHub
Star

Showing 7,777 of 7,777 total issues

File jquery.js has 7143 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jQuery JavaScript Library v3.5.1
 * https://jquery.com/
 *
 * Includes Sizzle.js
Severity: Major
Found in zk/src/main/resources/web/js/zk/ext/jquery.js - About 2 wks to fix

    File moment.js has 4580 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    //! moment.js
//! version : 2.29.4
//! authors : Tim Wood, Iskren Chernev, Moment.js contributors
//! license : MIT
//! momentjs.com
    Severity: Major
    Found in zk/src/main/resources/web/js/zk/ext/moment.js - About 1 wk to fix

      File d3.js has 3443 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      (function(){if (!Date.now) Date.now = function() {
  return +new Date;
};
try {
  document.createElement("div").style.setProperty("opacity", 0, "");
      Severity: Major
      Found in zktest/src/main/webapp/js/d3.js - About 1 wk to fix

        Function Sizzle has 1734 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        ( function( window ) {
var i,
    support,
    Expr,
    getText,
        Severity: Major
        Found in zk/src/main/resources/web/js/zk/ext/jquery.js - About 1 wk to fix

          Method jjMoveNfa_2 has a Cognitive Complexity of 413 (exceeds 5 allowed). Consider refactoring.
          Open

          private int jjMoveNfa_2(int startState, int curPos)
{
   int startsAt = 0;
   jjnewStateCnt = 30;
   int i = 1;
          Severity: Minor
          Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java - About 1 wk to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method jjMoveNfa_1 has a Cognitive Complexity of 413 (exceeds 5 allowed). Consider refactoring.
          Open

          private int jjMoveNfa_1(int startState, int curPos)
{
   int startsAt = 0;
   jjnewStateCnt = 30;
   int i = 1;
          Severity: Minor
          Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java - About 1 wk to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File AbstractComponent.java has 2933 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /* AbstractComponent.java

    Purpose:

    Description:
          Severity: Major
          Found in zk/src/main/java/org/zkoss/zk/ui/AbstractComponent.java - About 1 wk to fix

            File ELParser.java has 2789 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /* Generated By:JJTree&JavaCC: Do not edit this line. ELParser.java */
package org.zkoss.zel.impl.parser;
import java.io.StringReader;

import org.zkoss.zel.ELException;
            Severity: Major
            Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParser.java - About 1 wk to fix

              File Listbox.java has 2658 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              /* Listbox.java

    Purpose:

    Description:
              Severity: Major
              Found in zul/src/main/java/org/zkoss/zul/Listbox.java - About 1 wk to fix

                Function parseDate has a Cognitive Complexity of 340 (exceeds 5 allowed). Consider refactoring.
                Open

                    parseDate(
        txt: string,
        fmt: string,
        nonLenient?: boolean,
        refval?: DateImpl,
                Severity: Minor
                Found in zul/src/main/resources/web/js/zul/db/datefmt.ts - About 1 wk to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File BinderImpl.java has 2385 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                /* BinderImpl.java

    Purpose:
        
    Description:
                Severity: Major
                Found in zkbind/src/main/java/org/zkoss/bind/impl/BinderImpl.java - About 6 days to fix

                  Method parseItem has a Cognitive Complexity of 303 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private Object parseItem(PageDefinition pgdef, NodeInfo parent, Element el, AnnotationHelper annHelper,
            boolean bNativeContent, ParsingState parsingState) throws Exception {
        final String nm = el.getLocalName();
        final Namespace ns = el.getNamespace();
        final String pref = ns != null ? ns.getPrefix() : "";
                  Severity: Minor
                  Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/Parser.java - About 6 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File Tree.java has 2159 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /* Tree.java

    Purpose:

    Description:
                  Severity: Major
                  Found in zul/src/main/java/org/zkoss/zul/Tree.java - About 5 days to fix

                    File ELParserTokenManager.java has 2104 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    /* Generated By:JJTree&JavaCC: Do not edit this line. ELParserTokenManager.java */
package org.zkoss.zel.impl.parser;
import java.io.StringReader;

import org.zkoss.zel.ELException;
                    Severity: Major
                    Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java - About 5 days to fix

                      File UiEngineImpl.java has 2078 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /* UiEngineImpl.java

    Purpose:
        
    Description:
                      Severity: Major
                      Found in zk/src/main/java/org/zkoss/zk/ui/impl/UiEngineImpl.java - About 5 days to fix

                        Method service has a Cognitive Complexity of 276 (exceeds 5 allowed). Consider refactoring.
                        Open

                            @SuppressWarnings({ "rawtypes", "unchecked" })
    public void service(org.zkoss.zk.au.AuRequest request, boolean everError) {
        final String cmd = request.getCommand();
        if (cmd.equals(Events.ON_DATA_LOADING)) {
            if (_rod) {
                        Severity: Minor
                        Found in zul/src/main/java/org/zkoss/zul/Listbox.java - About 5 days to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                [109536, 120312, 86976, 109040, 120060, 86496, 108792, 119934, 86256,
            108668, 86136, 129744, 89056, 110072, 129736, 88560, 109820, 129732, 88312,
            109694,
            129730, 88188, 128464, 129772, 89592, 128456, 129766, 89340, 128452, 89214,
            128450, 125904, 128492, 125896, 128486, 125892, 125890, 120784, 125932,
                        Severity: Major
                        Found in zktest/src/main/webapp/test2/js/zk-3913-PDF417lib.js and 2 other locations - About 5 days to fix
                        zktest/src/main/webapp/test2/js/zk-3913-PDF417lib.js on lines 533..634
                        zktest/src/main/webapp/test2/js/zk-3913-PDF417lib.js on lines 635..738

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 931.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                [128352, 129720, 125504, 128304, 129692, 125472, 128280, 129678, 125456,
            128268, 125448, 128262, 125444, 125792, 128440, 129758, 120384, 125744,
            128412, 120352, 125720, 128398, 120336, 125708, 120328, 125702, 120324,
            120672, 125880, 128478, 110144, 120624, 125852, 110112, 120600, 125838,
            110096, 120588, 110088, 120582, 110084,
                        Severity: Major
                        Found in zktest/src/main/webapp/test2/js/zk-3913-PDF417lib.js and 2 other locations - About 5 days to fix
                        zktest/src/main/webapp/test2/js/zk-3913-PDF417lib.js on lines 533..634
                        zktest/src/main/webapp/test2/js/zk-3913-PDF417lib.js on lines 739..837

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 931.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                [120256, 125680, 128380, 120032, 125560, 128318, 108736, 119920, 108640,
            86080, 108592, 86048, 110016, 120560, 125820, 109792, 120440, 125758,
            88256, 109680, 88160, 89536, 110320, 120700, 89312, 110200, 120638, 89200,
            110140, 89840, 110460, 89720, 110398, 89980, 128506, 119520, 125304,
            128190, 107712, 119408, 125244, 107616, 119352, 84032, 107568, 119324,
                        Severity: Major
                        Found in zktest/src/main/webapp/test2/js/zk-3913-PDF417lib.js and 2 other locations - About 5 days to fix
                        zktest/src/main/webapp/test2/js/zk-3913-PDF417lib.js on lines 635..738
                        zktest/src/main/webapp/test2/js/zk-3913-PDF417lib.js on lines 739..837

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 931.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        AbstractComponent has 263 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        public class AbstractComponent implements Component, ComponentCtrl, java.io.Serializable {
    private static final Logger log = LoggerFactory.getLogger(AbstractComponent.class);
    private static final long serialVersionUID = 20100719L;

    /** Map(Class, Map(String name, Integer flags)). */
                        Severity: Major
                        Found in zk/src/main/java/org/zkoss/zk/ui/AbstractComponent.java - About 5 days to fix
                          Severity
                          Category
                          Status
                          Source
                          Language