Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/resources/web/js/zk/ext/fetch.js

Summary

Maintainability
D
2 days
Test Coverage

File fetch.js has 367 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* fetch.js

    Purpose:

    Description:
Severity: Minor
Found in zk/src/main/resources/web/js/zk/ext/fetch.js - About 4 hrs to fix

    Function ajaxFetch has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        self.ajaxFetch = function (input, init) {
        return new Promise(function (resolve, reject) {
            var request
            if (Request.prototype.isPrototypeOf(input) && !init) {
                request = input
    Severity: Major
    Found in zk/src/main/resources/web/js/zk/ext/fetch.js - About 3 hrs to fix

      Function Body has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function Body() {
        this.bodyUsed = false


        this._initBody = function (body) {
      Severity: Major
      Found in zk/src/main/resources/web/js/zk/ext/fetch.js - About 2 hrs to fix

        Function Request has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function Request(input, options) {
        options = options || {}
        var body = options.body
        if (Request.prototype.isPrototypeOf(input)) {
            if (input.bodyUsed) {
        Severity: Minor
        Found in zk/src/main/resources/web/js/zk/ext/fetch.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (uploadCallbacks.length) {
                    for (var i = 0, j = uploadCallbacks.length; i < j; i++) {
                        if (uploadCallbacks[i]['onerror']) {
                            uploadCallbacks[i]['onerror'].apply(xhr, arguments);
                        }
          Severity: Major
          Found in zk/src/main/resources/web/js/zk/ext/fetch.js and 1 other location - About 2 hrs to fix
          zk/src/main/resources/web/js/zk/ext/fetch.js on lines 361..367

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (uploadCallbacks.length) {
                    for (var i = 0, j = uploadCallbacks.length; i < j; i++) {
                        if (uploadCallbacks[i]['onload']) {
                            uploadCallbacks[i]['onload'].apply(xhr, arguments);
                        }
          Severity: Major
          Found in zk/src/main/resources/web/js/zk/ext/fetch.js and 1 other location - About 2 hrs to fix
          zk/src/main/resources/web/js/zk/ext/fetch.js on lines 385..391

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status