znamenica/dneslov

View on GitHub
app/models/item_type.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

   scope :by_token, -> text { joins(:descriptions).where( "unaccent(descriptions.text) ~* unaccent(?)", "\\m#{text}.*" ) }
Severity: Minor
Found in app/models/item_type.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Space inside parentheses detected.
Open

   scope :by_token, -> text { joins(:descriptions).where( "unaccent(descriptions.text) ~* unaccent(?)", "\\m#{text}.*" ) }
Severity: Minor
Found in app/models/item_type.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Wrap stabby lambda arguments with parentheses.
Open

   scope :descriptions_for, -> language_code { joins(:descriptions).where(descriptions: { language_code: language_code }) }
Severity: Minor
Found in app/models/item_type.rb by rubocop

Check for parentheses around stabby lambda arguments. There are two different styles. Defaults to require_parentheses.

Example: EnforcedStyle: require_parentheses (default)

# bad
->a,b,c { a + b + c }

# good
->(a,b,c) { a + b + c}

Example: EnforcedStyle: requirenoparentheses

# bad
->(a,b,c) { a + b + c }

# good
->a,b,c { a + b + c}

Do not use spaces between -> and opening brace in lambda literals
Open

   scope :by_token, -> text { joins(:descriptions).where( "unaccent(descriptions.text) ~* unaccent(?)", "\\m#{text}.*" ) }
Severity: Minor
Found in app/models/item_type.rb by rubocop

This cop checks for spaces between -> and opening parameter brace in lambda literals.

Example: EnforcedStyle: requirenospace (default)

# bad
  a = -> (x, y) { x + y }

  # good
  a = ->(x, y) { x + y }

Example: EnforcedStyle: require_space

# bad
  a = ->(x, y) { x + y }

  # good
  a = -> (x, y) { x + y }

Space inside parentheses detected.
Open

   scope :by_token, -> text { joins(:descriptions).where( "unaccent(descriptions.text) ~* unaccent(?)", "\\m#{text}.*" ) }
Severity: Minor
Found in app/models/item_type.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Do not use spaces between -> and opening brace in lambda literals
Open

   scope :descriptions_for, -> language_code { joins(:descriptions).where(descriptions: { language_code: language_code }) }
Severity: Minor
Found in app/models/item_type.rb by rubocop

This cop checks for spaces between -> and opening parameter brace in lambda literals.

Example: EnforcedStyle: requirenospace (default)

# bad
  a = -> (x, y) { x + y }

  # good
  a = ->(x, y) { x + y }

Example: EnforcedStyle: require_space

# bad
  a = ->(x, y) { x + y }

  # good
  a = -> (x, y) { x + y }

Missing top-level class documentation comment.
Open

class ItemType < ActiveRecord::Base
Severity: Minor
Found in app/models/item_type.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Wrap stabby lambda arguments with parentheses.
Open

   scope :by_token, -> text { joins(:descriptions).where( "unaccent(descriptions.text) ~* unaccent(?)", "\\m#{text}.*" ) }
Severity: Minor
Found in app/models/item_type.rb by rubocop

Check for parentheses around stabby lambda arguments. There are two different styles. Defaults to require_parentheses.

Example: EnforcedStyle: require_parentheses (default)

# bad
->a,b,c { a + b + c }

# good
->(a,b,c) { a + b + c}

Example: EnforcedStyle: requirenoparentheses

# bad
->(a,b,c) { a + b + c }

# good
->a,b,c { a + b + c}

There are no issues that match your filters.

Category
Status