Sign upLogin

znamenica/dneslov

View on GitHub
Star

Showing 2,171 of 2,171 total issues

Replace class var @@default_key with a class instance var.
Open

      @@default_key = key ;end
Severity: Minor
Found in app/models/concerns/default_key.rb by rubocop

This cop checks for uses of class variables. Offenses are signaled only on assignment to class variables to reduce the number of offenses that would be reported.

Space inside parentheses detected.
Open

   scope :for_calendary, -> { where( sluggable_type: 'Calendary' ) }
Severity: Minor
Found in app/models/slug.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Place the end statement of a multi-line method on its own line.
Open

      klass.include( InstanceMethods ) ;end ;end
Severity: Minor
Found in app/models/concerns/default_key.rb by rubocop

This cop checks for trailing code after the method definition.

Example:

# bad
def some_method
do_stuff; end

def do_this(x)
  baz.map { |b| b.this(x) } end

def foo
  block do
    bar
  end end

# good
def some_method
  do_stuff
end

def do_this(x)
  baz.map { |b| b.this(x) }
end

def foo
  block do
    bar
  end
end

Missing top-level module documentation comment.
Open

module WithLinks
Severity: Minor
Found in app/models/concerns/with_links.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing space after #.
Open

            # TODO fix the correctness of the query
Severity: Minor
Found in app/models/concerns/tokens.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Indent the first line of the right-hand-side of a multi-line assignment.
Open

                               "OR titles.describable_id = #{as}_kinds.id
                               AND titles.describable_type = 'Subject'
                               AND titles.type = 'Appellation'"
Severity: Minor
Found in app/models/concerns/with_titles.rb by rubocop

This cop checks the indentation of the first line of the right-hand-side of a multi-line assignment.

Example:

# bad
value =
if foo
  'bar'
end

# good
value =
  if foo
    'bar'
  end

The indentation of the remaining lines can be corrected with other cops such as IndentationConsistency and EndAlignment.

unexpected token tRBRACK (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

      self.bind_kind_path = [parent&.store_bind_kind_path!, bind_kind.order].compact.join(".")
Severity: Minor
Found in app/models/nomen.rb by rubocop

unexpected token error (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

      @alphabeth ||= titles.first&.alphabeth_code || descriptions.first&.language_code
Severity: Minor
Found in app/models/picture.rb by rubocop

Space inside parentheses detected.
Open

      if self.respond_to?( :default_key )
Severity: Minor
Found in app/models/concerns/default_key.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

end at 8, 27 is not aligned with def at 7, 3.
Open

      @@default_key = key ;end
Severity: Minor
Found in app/models/concerns/default_key.rb by rubocop

This cop checks whether the end keywords of method definitions are aligned properly.

Two modes are supported through the EnforcedStyleAlignWith configuration parameter. If it's set to start_of_line (which is the default), the end shall be aligned with the start of the line where the def keyword is. If it's set to def, the end shall be aligned with the def keyword.

Example: EnforcedStyleAlignWith: startofline (default)

# bad

private def foo
            end

# good

private def foo
end

Example: EnforcedStyleAlignWith: def

# bad

private def foo
            end

# good

private def foo
        end

end at 11, 30 is not aligned with def at 10, 3.
Open

      self.default_key = key ;end
Severity: Minor
Found in app/models/concerns/default_key.rb by rubocop

This cop checks whether the end keywords of method definitions are aligned properly.

Two modes are supported through the EnforcedStyleAlignWith configuration parameter. If it's set to start_of_line (which is the default), the end shall be aligned with the start of the line where the def keyword is. If it's set to def, the end shall be aligned with the def keyword.

Example: EnforcedStyleAlignWith: startofline (default)

# bad

private def foo
            end

# good

private def foo
end

Example: EnforcedStyleAlignWith: def

# bad

private def foo
            end

# good

private def foo
        end

Use only ascii symbols in comments.
Open

            # TODO fix the correctness of the query
Severity: Minor
Found in app/models/concerns/tokens.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

Missing top-level module documentation comment.
Open

module Tokens
Severity: Minor
Found in app/models/concerns/tokens.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Do not use spaces between -> and opening brace in lambda literals
Open

         scope :by_title, -> title do
            joins(:titles).where(titles: { text: title })
         end
Severity: Minor
Found in app/models/concerns/with_titles.rb by rubocop

This cop checks for spaces between -> and opening parameter brace in lambda literals.

Example: EnforcedStyle: requirenospace (default)

# bad
  a = -> (x, y) { x + y }

  # good
  a = ->(x, y) { x + y }

Example: EnforcedStyle: require_space

# bad
  a = ->(x, y) { x + y }

  # good
  a = -> (x, y) { x + y }

Do not use spaces between -> and opening brace in lambda literals
Open

         scope :with_title, -> context do
            as = table.table_alias || table.name
            language_codes = [context[:locales]].flatten

            selector = self.select_values.dup
Severity: Minor
Found in app/models/concerns/with_titles.rb by rubocop

This cop checks for spaces between -> and opening parameter brace in lambda literals.

Example: EnforcedStyle: requirenospace (default)

# bad
  a = -> (x, y) { x + y }

  # good
  a = ->(x, y) { x + y }

Example: EnforcedStyle: require_space

# bad
  a = ->(x, y) { x + y }

  # good
  a = -> (x, y) { x + y }

Space inside parentheses detected.
Open

            alphabeth_codes = Languageble.alphabeth_list_for( language_codes ).flatten
Severity: Minor
Found in app/models/concerns/with_titles.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Surrounding space missing for operator <.
Open

class ApplicationRecord< ActiveRecord::Base
Severity: Minor
Found in app/models/application_record.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

unexpected token error (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

      @description ||= descriptions.where(language_code: language, alphabeth_code: alphabeth).first&.text
Severity: Minor
Found in app/models/picture.rb by rubocop

Do not use space inside reference brackets.
Open

         last = words[ 1 ].gsub( /[аеёиоуъыьэюя]+/, '' )[ 0...3 ]
Severity: Minor
Found in app/models/slug.rb by rubocop

Checks that reference brackets have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: no_space (default)

# The `no_space` style enforces that reference brackets have
# no surrounding space.

# bad
hash[ :key ]
array[ index ]

# good
hash[:key]
array[index]

Example: EnforcedStyle: space

# The `space` style enforces that reference brackets have
# surrounding space.

# bad
hash[:key]
array[index]

# good
hash[ :key ]
array[ index ]

end at 5, 33 is not aligned with class at 1, 0.
Open

   validates_presence_of :order ;end
Severity: Minor
Found in app/models/memo_order.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)
Severity
Category
Status
Source
Language