Sign upLogin

znamenica/dneslov

View on GitHub
Star

Showing 2,171 of 2,171 total issues

Unnecessary spacing detected.
Open

   validates :prosomeion_title, absence: true, if: ->{ true }  # TODO validate why fails on descendants
Severity: Minor
Found in app/models/scriptum/cantoes/canticle.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

Missing top-level class documentation comment.
Open

class Admin::OrdersController < Admin::CommonController
Severity: Minor
Found in app/controllers/admin/orders_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Space missing after semicolon.
Open

               v ;end;end
Severity: Minor
Found in app/models/scriptum/canto.rb by rubocop

Checks for semicolon (;) not followed by some kind of space.

Example:

# bad
x = 1;y = 2

# good
x = 1; y = 2

%i-literals should be delimited by [ and ].
Open

         notes_attributes: %i(id text language_code alphabeth_code _destroy),
Severity: Minor
Found in app/controllers/admin/orders_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

unexpected token tCOLON (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

         'login': user_info['login'],
Severity: Minor
Found in app/controllers/concerns/github_auth.rb by rubocop

%i-literals should be delimited by [ and ].
Open

         links_attributes: %i(id url language_code alphabeth_code type _destroy),
Severity: Minor
Found in app/controllers/admin/orders_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Use nested module/class definitions instead of compact style.
Open

class Admin::MemoriesController < Admin::CommonController
Severity: Minor
Found in app/controllers/admin/memories_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Space missing after semicolon.
Open

      Admin::ItemsSerializer ;end;end
Severity: Minor
Found in app/controllers/admin/items_controller.rb by rubocop

Checks for semicolon (;) not followed by some kind of space.

Example:

# bad
x = 1;y = 2

# good
x = 1; y = 2

end at 14, 30 is not aligned with def at 13, 3.
Open

      Admin::ItemsSerializer ;end;end
Severity: Minor
Found in app/controllers/admin/items_controller.rb by rubocop

This cop checks whether the end keywords of method definitions are aligned properly.

Two modes are supported through the EnforcedStyleAlignWith configuration parameter. If it's set to start_of_line (which is the default), the end shall be aligned with the start of the line where the def keyword is. If it's set to def, the end shall be aligned with the def keyword.

Example: EnforcedStyleAlignWith: startofline (default)

# bad

private def foo
            end

# good

private def foo
end

Example: EnforcedStyleAlignWith: def

# bad

private def foo
            end

# good

private def foo
        end

Use nested module/class definitions instead of compact style.
Open

class Admin::NamesController < Admin::CommonController
Severity: Minor
Found in app/controllers/admin/names_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Use nested module/class definitions instead of compact style.
Open

class Admin::NominaController < Admin::CommonController
Severity: Minor
Found in app/controllers/admin/nomina_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Indent the first line of the right-hand-side of a multi-line assignment.
Open

      if params[ :t ]
         model.by_token(params[ :t ])
      elsif params[ :v ] && params[ :value_name ]
         model.where(params[ :v ] => params[ :v ])
      else
Severity: Minor
Found in app/controllers/admin/places_controller.rb by rubocop

This cop checks the indentation of the first line of the right-hand-side of a multi-line assignment.

Example:

# bad
value =
if foo
  'bar'
end

# good
value =
  if foo
    'bar'
  end

The indentation of the remaining lines can be corrected with other cops such as IndentationConsistency and EndAlignment.

Do not use space inside reference brackets.
Open

         model.where(params[ :v ] => params[ :v ])
Severity: Minor
Found in app/controllers/admin/places_controller.rb by rubocop

Checks that reference brackets have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: no_space (default)

# The `no_space` style enforces that reference brackets have
# no surrounding space.

# bad
hash[ :key ]
array[ index ]

# good
hash[:key]
array[index]

Example: EnforcedStyle: space

# The `space` style enforces that reference brackets have
# surrounding space.

# bad
hash[:key]
array[index]

# good
hash[ :key ]
array[ index ]

Space missing after semicolon.
Open

      params.require( :place ).permit() ;end
Severity: Minor
Found in app/controllers/admin/places_controller.rb by rubocop

Checks for semicolon (;) not followed by some kind of space.

Example:

# bad
x = 1;y = 2

# good
x = 1; y = 2

end at 19, 41 is not aligned with def at 18, 3.
Open

      params.require( :place ).permit() ;end
Severity: Minor
Found in app/controllers/admin/places_controller.rb by rubocop

This cop checks whether the end keywords of method definitions are aligned properly.

Two modes are supported through the EnforcedStyleAlignWith configuration parameter. If it's set to start_of_line (which is the default), the end shall be aligned with the start of the line where the def keyword is. If it's set to def, the end shall be aligned with the def keyword.

Example: EnforcedStyleAlignWith: startofline (default)

# bad

private def foo
            end

# good

private def foo
end

Example: EnforcedStyleAlignWith: def

# bad

private def foo
            end

# good

private def foo
        end

Use nested module/class definitions instead of compact style.
Open

class Admin::PlacesController < Admin::CommonController
Severity: Minor
Found in app/controllers/admin/places_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Space inside parentheses detected.
Open

      params.require( :place ).permit() ;end
Severity: Minor
Found in app/controllers/admin/places_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Align the operands of an expression in an assignment spanning multiple lines.
Open

            (e.class.to_s != e.message ? e.message : ""),
Severity: Minor
Found in app/controllers/application_controller.rb by rubocop

This cop checks the indentation of the right hand side operand in binary operations that span more than one line.

Example:

# bad
if a +
b
  something
end

# good
if a +
   b
  something
end

Missing top-level class documentation comment.
Open

class Api::V1::CalendariesController < Api::CommonController
Severity: Minor
Found in app/controllers/api/v1/calendaries_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

class ApplicationController < ActionController::Base
Severity: Minor
Found in app/controllers/application_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end
Severity
Category
Status
Source
Language