Sign upLogin

znamenica/dneslov

View on GitHub
Star

Showing 2,171 of 2,171 total issues

end at 2, 54 is not aligned with class at 1, 0.
Open

   validates :prosomeion_title, :tone, absence: true ;end
Severity: Minor
Found in app/models/scriptum/cantoes/orison.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

                              "events_memories.short_name")
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Duplicated key in hash literal.
Open

         ('01.08'..'14.08') => {
Severity: Minor
Found in app/services/memo_service.rb by rubocop

This cop checks for duplicated keys in hash literals.

This cop mirrors a warning in Ruby 2.2.

Example:

# bad

hash = { food: 'apple', food: 'orange' }

Example:

# good

hash = { food: 'apple', other_food: 'orange' }

Use only ascii symbols in comments.
Open

   validates :prosomeion_title, absence: true, if: ->{ true }  # TODO validate why fails on descendants
Severity: Minor
Found in app/models/scriptum/cantoes/canticle.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

Freeze mutable objects assigned to constants.
Open

   TYPES = %w(Canto Chant Canticle Orison Magnification Prayer Irmos IkosTroparion
              Stichira Kontakion Exapostilarion SessionalHymn Kanonion Kathismion
              Polileosion Apostichus CryStichira Stichiron)
Severity: Minor
Found in app/models/scriptum/canto.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

unexpected token tCOLON (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

         'name': user_info['name'],
Severity: Minor
Found in app/controllers/concerns/github_auth.rb by rubocop

unexpected token tRCURLY (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

      }
Severity: Minor
Found in app/controllers/concerns/github_auth.rb by rubocop

unexpected token error (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

      params['c']&.split(',')&.select {|x| x =~ Slug::RE } || []
Severity: Minor
Found in app/controllers/memories_controller.rb by rubocop

%i-literals should be delimited by [ and ].
Open

         tweets_attributes: %i(id text language_code alphabeth_code _destroy),
Severity: Minor
Found in app/controllers/admin/orders_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Space found before semicolon.
Open

      params.require( :item ).permit() ;end
Severity: Minor
Found in app/controllers/admin/items_controller.rb by rubocop

Checks for semicolon (;) preceded by space.

Example:

# bad
x = 1 ; y = 2

# good
x = 1; y = 2

end at 25, 35 is not aligned with class at 1, 0.
Open

      Admin::PlacesSerializer ;end;end
Severity: Minor
Found in app/controllers/admin/places_controller.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

Space missing after semicolon.
Open

      %w(with_titles with_descriptions) ;end
Severity: Minor
Found in app/controllers/admin/events_controller.rb by rubocop

Checks for semicolon (;) not followed by some kind of space.

Example:

# bad
x = 1;y = 2

# good
x = 1; y = 2

Use nested module/class definitions instead of compact style.
Open

class Admin::EventsController < Admin::CommonController
Severity: Minor
Found in app/controllers/admin/events_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

%i-literals should be delimited by [ and ].
Open

   has_scope :by_memory_id, only: %i(index all)
Severity: Minor
Found in app/controllers/admin/memoes_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

%i-literals should be delimited by [ and ].
Open

   has_scope :by_calendary_id, only: %i(index all)
Severity: Minor
Found in app/controllers/admin/memoes_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

%i-literals should be delimited by [ and ].
Open

   has_scope :t, only: %i(memoried)
Severity: Minor
Found in app/controllers/admin/memoes_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

%i-literals should be delimited by [ and ].
Open

         memo_orders_attributes: %i(id order_id _destroy),
Severity: Minor
Found in app/controllers/admin/memoes_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

%i-literals should be delimited by [ and ].
Open

         notes_attributes: %i(id text language_code alphabeth_code _destroy),
Severity: Minor
Found in app/controllers/admin/memoes_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

%i-literals should be delimited by [ and ].
Open

         descriptions_attributes: %i(id text language_code alphabeth_code _destroy) )
Severity: Minor
Found in app/controllers/admin/subjects_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

%w-literals should be delimited by [ and ].
Open

      %w(with_markups with_descriptions)
Severity: Minor
Found in app/controllers/admin/readings_controller.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)
Severity
Category
Status
Source
Language