Sign upLogin

zodern/meteor-up

View on GitHub
Star

Showing 160 of 160 total issues

Function status has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function status(api) {
  const config = api.getConfig();
  const lines = [];
  let overallColor = 'green';
Severity: Major
Found in src/plugins/proxy/command-handlers.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        toRemove = toRemove.map(data => {
      data.node = curriedFindNodeId(data.server);

      if (!data.node) {
        console.error(`Unable to remove "${data.label}" label for server "${data.server}": Server doesn't have a node id.`);
    Severity: Major
    Found in src/plugins/docker/command-handlers.js and 1 other location - About 2 hrs to fix
    src/plugins/docker/command-handlers.js on lines 187..195

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        toAdd = toAdd.map(data => {
      data.node = curriedFindNodeId(data.server);

      if (!data.node) {
        console.log(`Unable to update "${data.label}" label for server "${data.server}": Server doesn't have a node id.`);
    Severity: Major
    Found in src/plugins/docker/command-handlers.js and 1 other location - About 2 hrs to fix
    src/plugins/docker/command-handlers.js on lines 177..185

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export function promoteNodes(manager, nodeIds, api) {
  const list = nodemiral.taskList('Promoting Nodes to Managers');

  log('promoting nodes:', nodeIds);
  list.executeScript('Promoting Nodes', {
    Severity: Major
    Found in src/plugins/docker/swarm.js and 1 other location - About 2 hrs to fix
    src/plugins/docker/swarm.js on lines 32..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export function initSwarm(manager, host, api) {
  const list = nodemiral.taskList('Setting Up Docker Swarm');

  log('creating manager', manager);
  list.executeScript('Creating Manager', {
    Severity: Major
    Found in src/plugins/docker/swarm.js and 1 other location - About 2 hrs to fix
    src/plugins/docker/swarm.js on lines 46..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File utils.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Client } from 'ssh2-classic';
import debug from 'debug';
import expandTilde from 'expand-tilde';
import fs from 'fs';
import net from 'net';
    Severity: Minor
    Found in src/utils.js - About 2 hrs to fix

      Function getInformation has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function getInformation(server, appName, api) {
  return api.runSSHCommand(server, `sudo docker inspect ${appName} --format "{{json .}}"`)
    // eslint-disable-next-line complexity
    .then(({ host, output }) => {
      let info;
      Severity: Major
      Found in src/plugins/meteor/status.js - About 2 hrs to fix

        Function reconfigShared has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function reconfigShared(api) {
  const config = api.getConfig().proxy;
  const shared = config.shared || {};

  if (!config) {
        Severity: Major
        Found in src/plugins/proxy/command-handlers.js - About 2 hrs to fix

          Function status has 59 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export async function status(api) {
  const config = api.getConfig();
  const swarmEnabled = api.swarmEnabled();

  if (!config.servers) {
          Severity: Major
          Found in src/plugins/docker/command-handlers.js - About 2 hrs to fix

            Function status has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export async function status(api) {
  const config = api.getConfig();

  if (!config.mongo) {
    return;
            Severity: Major
            Found in src/plugins/mongo/command-handlers.js - About 2 hrs to fix

              File command-handlers.js has 257 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              import { checkVersion, shouldShowDockerWarning } from './utils';
import {
  curry,
  difference,
  intersection
              Severity: Minor
              Found in src/plugins/docker/command-handlers.js - About 2 hrs to fix

                Function 'envconfig' has a complexity of 13.
                Open

                export function envconfig(api) {
                Severity: Minor
                Found in src/plugins/meteor/command-handlers.js by eslint

                Limit Cyclomatic Complexity (complexity)

                Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

                Rule Details

                This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                Examples of incorrect code for a maximum of 2:

                /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

                Examples of correct code for a maximum of 2:

                /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

                Options

                Optionally, you may specify a max object property:

                "complexity": ["error", 2]

                is equivalent to

                "complexity": ["error", { "max": 2 }]

                Deprecated: the object property maximum is deprecated. Please use the property max instead.

                When Not To Use It

                If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                Further Reading

                Related Rules

                • [max-depth](max-depth.md)
                • [max-len](max-len.md)
                • [max-nested-callbacks](max-nested-callbacks.md)
                • [max-params](max-params.md)
                • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                Function scrubConfig has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                Open

                export function scrubConfig(config, { scrubUrl }) {
  if (!config.proxy) {
    return config;
  }
                Severity: Minor
                Found in src/plugins/proxy/index.js - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function prepareBundle has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export async function prepareBundle(api) {
  log('exec => mup meteor prepare-bundle');
  const {
    app: appConfig,
    privateDockerRegistry
                Severity: Major
                Found in src/plugins/meteor/command-handlers.js - About 2 hrs to fix

                  Method '_loadSessions' has a complexity of 12.
                  Open

                    _loadSessions() {
                  Severity: Minor
                  Found in src/plugin-api.js by eslint

                  Limit Cyclomatic Complexity (complexity)

                  Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                  function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

                  Rule Details

                  This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                  Examples of incorrect code for a maximum of 2:

                  /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

                  Examples of correct code for a maximum of 2:

                  /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

                  Options

                  Optionally, you may specify a max object property:

                  "complexity": ["error", 2]

                  is equivalent to

                  "complexity": ["error", { "max": 2 }]

                  Deprecated: the object property maximum is deprecated. Please use the property max instead.

                  When Not To Use It

                  If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                  Further Reading

                  Related Rules

                  • [max-depth](max-depth.md)
                  • [max-len](max-len.md)
                  • [max-nested-callbacks](max-nested-callbacks.md)
                  • [max-params](max-params.md)
                  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                  Function _loadSessions has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    _loadSessions() {
    const config = this.getConfig();

    this.sessions = {};
                  Severity: Minor
                  Found in src/plugin-api.js - About 1 hr to fix

                    Function retryWithAuth has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                    Open

                    async function retryWithAuth(
  registryConfig,
  { url, method, data, headers: _headers = {} }
) {
  const headers = {
                    Severity: Minor
                    Found in src/plugins/meteor/docker-registry.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export function validateSwarm(
  config,
  {
    addLocation,
    VALIDATE_OPTIONS,
                    Severity: Major
                    Found in src/plugins/docker/validate.js and 1 other location - About 1 hr to fix
                    src/plugins/docker/validate.js on lines 37..52

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 71.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export function validateRegistry(
  config,
  {
    addLocation,
    VALIDATE_OPTIONS,
                    Severity: Major
                    Found in src/plugins/docker/validate.js and 1 other location - About 1 hr to fix
                    src/plugins/docker/validate.js on lines 19..35

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 71.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Async function 'setupSwarm' has a complexity of 10.
                    Open

                    export async function setupSwarm(api) {
                    Severity: Minor
                    Found in src/plugins/docker/command-handlers.js by eslint

                    Limit Cyclomatic Complexity (complexity)

                    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                    function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

                    Rule Details

                    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                    Examples of incorrect code for a maximum of 2:

                    /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

                    Examples of correct code for a maximum of 2:

                    /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

                    Options

                    Optionally, you may specify a max object property:

                    "complexity": ["error", 2]

                    is equivalent to

                    "complexity": ["error", { "max": 2 }]

                    Deprecated: the object property maximum is deprecated. Please use the property max instead.

                    When Not To Use It

                    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                    Further Reading

                    Related Rules

                    • [max-depth](max-depth.md)
                    • [max-len](max-len.md)
                    • [max-nested-callbacks](max-nested-callbacks.md)
                    • [max-params](max-params.md)
                    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/
                    Severity
                    Category
                    Status
                    Source
                    Language