Sign upLogin

zold-io/zold

View on GitHub
Star
lib/zold/commands/fetch.rb

Summary

Maintainability
C
1 day
Test Coverage

Method fetch_one has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def fetch_one(id, r, cps, opts)
      if opts['ignore-node'].include?(r.to_s)
        @log.debug("#{r} ignored because of --ignore-node")
        return 0
      end
Severity: Minor
Found in lib/zold/commands/fetch.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fetch has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def fetch(id, cps, opts)
      if @remotes.all.empty?
        return if opts['quiet-if-absent']
        raise "There are no remote nodes, run 'zold remote reset'"
      end
Severity: Minor
Found in lib/zold/commands/fetch.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def run(args = [])
      opts = Slop.parse(args, help: true, suppress_errors: true) do |o|
        o.banner = "Usage: zold fetch [ID...] [options]
Available options:"
        o.bool '--ignore-score-weakness',
Severity: Minor
Found in lib/zold/commands/fetch.rb - About 1 hr to fix

    Method fetch has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def fetch(id, cps, opts)
      if @remotes.all.empty?
        return if opts['quiet-if-absent']
        raise "There are no remote nodes, run 'zold remote reset'"
      end
    Severity: Minor
    Found in lib/zold/commands/fetch.rb - About 1 hr to fix

      Method fetch_one has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def fetch_one(id, r, cps, opts)
      if opts['ignore-node'].include?(r.to_s)
        @log.debug("#{r} ignored because of --ignore-node")
        return 0
      end
      Severity: Minor
      Found in lib/zold/commands/fetch.rb - About 1 hr to fix

        Method existing_copy_added has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def existing_copy_added(id, cps, score, r, json)
        Severity: Minor
        Found in lib/zold/commands/fetch.rb - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  head = r.http(uri).get
        raise Fetch::Error, "The wallet #{id} doesn't exist at #{r}" if head.status == 404
        r.assert_code(200, head)
        json = JsonPage.new(head.body, uri).to_hash
        score = Score.parse_json(json['score'])
          Severity: Minor
          Found in lib/zold/commands/fetch.rb and 1 other location - About 45 mins to fix
          lib/zold/commands/push.rb on lines 162..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 39.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status