zold-io/zold

View on GitHub
lib/zold/commands/node.rb

Summary

Maintainability
F
3 days
Test Coverage

Method run has 255 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def run(args = [])
      opts = Slop.parse(args, help: true, suppress_errors: true) do |o|
        o.banner = 'Usage: zold node [options]'
        o.string '--invoice',
          'The invoice you want to collect money to or the wallet ID',
Severity: Major
Found in lib/zold/commands/node.rb - About 1 day to fix

    File node.rb has 478 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'open3'
    require 'slop'
    require 'shellwords'
    require 'backtrace'
    require 'fileutils'
    Severity: Minor
    Found in lib/zold/commands/node.rb - About 7 hrs to fix

      Method run has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          def run(args = [])
            opts = Slop.parse(args, help: true, suppress_errors: true) do |o|
              o.banner = 'Usage: zold node [options]'
              o.string '--invoice',
                'The invoice you want to collect money to or the wallet ID',
      Severity: Minor
      Found in lib/zold/commands/node.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method nohup has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          def nohup(opts)
            pid = fork do
              nohup_log = NohupLog.new(opts['nohup-log'], opts['nohup-log-truncate'])
              Signal.trap('HUP') do
                nohup_log.print("Received HUP, ignoring...\n")
      Severity: Minor
      Found in lib/zold/commands/node.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method metronome has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def metronome(farm, opts, host, port)
            metronome = Metronome.new(@log)
            if opts['no-metronome']
              @log.info("Metronome hasn't been started because of --no-metronome")
              return metronome
      Severity: Minor
      Found in lib/zold/commands/node.rb - About 1 hr to fix

        Method nohup has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def nohup(opts)
              pid = fork do
                nohup_log = NohupLog.new(opts['nohup-log'], opts['nohup-log-truncate'])
                Signal.trap('HUP') do
                  nohup_log.print("Received HUP, ignoring...\n")
        Severity: Minor
        Found in lib/zold/commands/node.rb - About 1 hr to fix

          Method metronome has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def metronome(farm, opts, host, port)
                metronome = Metronome.new(@log)
                if opts['no-metronome']
                  @log.info("Metronome hasn't been started because of --no-metronome")
                  return metronome
          Severity: Minor
          Found in lib/zold/commands/node.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                invoice = opts['invoice']
                unless invoice.include?('@')
                  require_relative 'invoice'
                  invoice = Invoice.new(wallets: @wallets, remotes: @remotes, copies: @copies, log: @log).run(
                    ['invoice', invoice, "--network=#{Shellwords.escape(opts['network'])}"] +
          Severity: Minor
          Found in lib/zold/commands/node.rb and 1 other location - About 1 hr to fix
          lib/zold/commands/pay.rb on lines 94..99

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status