Sign upLogin

zordius/webtasks

View on GitHub
Star

Showing 5 of 5 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    module: function (name) {
        return subtask.after(locate.subtask(this, name, 'module'), function (T) {
            return T.transform(function (R) {
                return {view: 'module_' + name, data: R};
            }).pipe(render);
Severity: Major
Found in lib/context.js and 1 other location - About 2 hrs to fix
lib/context.js on lines 69..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    page: function (name) {
        return subtask.after(locate.subtask(this, name, 'page'), function (T) {
            return T.transform(function (R) {
                return {view: 'page_' + name, data: R};
            }).pipe(render);
Severity: Major
Found in lib/context.js and 1 other location - About 2 hrs to fix
lib/context.js on lines 62..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function middleware has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    middleware: function (type, name) {
        var task,
            trans,
            pipe;
Severity: Minor
Found in lib/webtask.js - About 1 hr to fix

    Function exports has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function (product_id) {
    // example: input validation
console.log('product id: ' + product_id);
    if (!product_id) {
        return this.task();
    Severity: Minor
    Found in data/getProduct.js - About 1 hr to fix

      Function react has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          react: function (name, dynamic) {
        var CX = this;
        return function () {
            var component,
                componentFactory,
      Severity: Minor
      Found in lib/context.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language