zotoio/github-task-manager

View on GitHub

Showing 36 of 44 total issues

File EventHandler.js has 380 lines of code (exceeds 300 allowed). Consider refactoring.
Open

'use strict';
import requireDir from 'require-dir';
import { Plugin } from './Plugin';
import { default as formatJson } from 'format-json';
import { Executor } from './Executor';
Severity: Minor
Found in src/agent/EventHandler.js - About 3 hrs to fix

    Function handler has 152 lines of code (exceeds 100 allowed). Consider refactoring.
    Open

    function handler(event, context, callback) {
        if (process.env.IAM_ENABLED) {
            AWS.config.update({
                httpOptions: {
                    agent: PROXY_AGENT(process.env.AWS_PROXY)
    Severity: Major
    Found in src/serverless/gtmGithubMetricCapture/gtmGithubMetricCapture.js - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (process.env.GTM_DYNAMO_VPCE) {
              console.log('Configuring DynamoDB to use VPC Endpoint');
              dynamo = new AWS.DynamoDB({
                  httpOptions: {
                      agent: new HTTPS.Agent()
      src/agent/AgentUtils.js on lines 397..407

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 89.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (process.env.GTM_DYNAMO_VPCE) {
                      log.info('Configuring DynamoDB to use VPC Endpoint');
                      DDB = new AWS.DynamoDB({
                          httpOptions: {
                              agent: new https.Agent()
      Severity: Major
      Found in src/agent/AgentUtils.js and 1 other location - About 2 hrs to fix
      src/serverless/gtmGithubMetricCapture/gtmGithubMetricCapture.js on lines 27..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 89.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  ddbStream.on('insert record', object => {
                      log.debug(`inserted ${json.plain(object)}`);
                      INITIAL_DATA[tableName].push(object);
                      sseStream.updateInit(INITIAL_DATA[tableName]);
                      sseStream.send(object);
      Severity: Major
      Found in src/agent/AgentMetrics.js and 1 other location - About 2 hrs to fix
      src/agent/AgentMetrics.js on lines 149..154

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 87.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  ddbStream.on('modify record', object => {
                      log.debug(`updated ${json.plain(object)}`);
                      INITIAL_DATA[tableName].push(object);
                      sseStream.updateInit(INITIAL_DATA[tableName]);
                      sseStream.send(object);
      Severity: Major
      Found in src/agent/AgentMetrics.js and 1 other location - About 2 hrs to fix
      src/agent/AgentMetrics.js on lines 142..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 87.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      AgentUtils has 27 functions (exceeds 25 allowed). Consider refactoring.
      Open

      export class AgentUtils {
          static agentId() {
              return AgentLogger.AGENT_ID;
          }
      
      
      Severity: Minor
      Found in src/agent/AgentUtils.js - About 2 hrs to fix

        File AgentUtils.js has 310 lines of code (exceeds 300 allowed). Consider refactoring.
        Open

        'use strict';
        
        const pullRequestData = require('./pullrequest.json');
        const { URL } = require('url');
        const crypto = require('crypto');
        Severity: Minor
        Found in src/agent/AgentUtils.js - About 2 hrs to fix

          File AgentMetrics.js has 306 lines of code (exceeds 300 allowed). Consider refactoring.
          Open

          import { default as ExpressSSE } from 'express-sse';
          import { default as AWS } from 'aws-sdk';
          import { default as AgentLogger } from './AgentLogger';
          import { default as json } from 'format-json';
          import { default as DynamoDBStream } from 'dynamodb-stream';
          Severity: Minor
          Found in src/agent/AgentMetrics.js - About 2 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (process.env.GTM_ELASTIC_HOST && process.env.GTM_ELASTIC_PORT) {
                                let baseUrl = process.env.GTM_BASE_URL || 'http://localhost:9091';
                                url = `${baseUrl}/metrics/log/gtm-${event.eventId}.txt`;
                            }
            Severity: Major
            Found in src/agent/EventHandler.js and 1 other location - About 1 hr to fix
            src/agent/EventHandler.js on lines 128..131

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (process.env.GTM_ELASTIC_HOST && process.env.GTM_ELASTIC_PORT) {
                        let baseUrl = process.env.GTM_BASE_URL || 'http://localhost:9091';
                        url = `${baseUrl}/metrics/log/gtm-${event.eventId}.txt`;
                    }
            Severity: Major
            Found in src/agent/EventHandler.js and 1 other location - About 1 hr to fix
            src/agent/EventHandler.js on lines 78..81

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function processTasks has 117 lines of code (exceeds 100 allowed). Consider refactoring.
            Open

                async processTasks(event, parent) {
                    let promises = [];
                    let log = this.log;
            
                    if (parent.tasks) {
            Severity: Major
            Found in src/agent/EventHandler.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      app.get('/metrics/health/detail', async (req, res) => {
                          let includeDetail = true;
                          let result = await this.getHealth(ddb, includeDetail);
                          res.json(result);
                          res.end();
              Severity: Major
              Found in src/agent/AgentMetrics.js and 1 other location - About 1 hr to fix
              src/agent/AgentMetrics.js on lines 83..88

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      app.get('/metrics/health', async (req, res) => {
                          let includeDetail = false;
                          let result = await this.getHealth(ddb, includeDetail);
                          res.json(result);
                          res.end();
              Severity: Major
              Found in src/agent/AgentMetrics.js and 1 other location - About 1 hr to fix
              src/agent/AgentMetrics.js on lines 90..95

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (this.validate(task, response)) {
                                  task.results = {
                                      passed: true,
                                      message: 'Request completed',
                                      url: 'http://www.softwareishard.com/blog/har-12-spec/#request',
              Severity: Major
              Found in src/executors/ExecutorHttp.js and 1 other location - About 1 hr to fix
              src/executors/ExecutorHttp.js on lines 58..66

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              } else {
                                  task.results = {
                                      passed: false,
                                      message: 'Response validation failed',
                                      url: 'http://www.softwareishard.com/blog/har-12-spec/#request',
              Severity: Major
              Found in src/executors/ExecutorHttp.js and 1 other location - About 1 hr to fix
              src/executors/ExecutorHttp.js on lines 50..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  if (process.env.AWS_PROXY) {
                      AWS.config.update({
                          httpOptions: {
                              agent: proxy(process.env.AWS_PROXY)
                          }
              Severity: Major
              Found in src/serverless/gtmGithubResults/gtmGithubResults.js and 3 other locations - About 55 mins to fix
              src/KmsUtils.js on lines 3..9
              src/agent/AgentMetrics.js on lines 33..39
              src/serverless/gtmGithubMetricCapture/gtmGithubMetricCapture.js on lines 18..24

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

              if (process.env.AWS_PROXY) {
                  AWS.config.update({
                      httpOptions: {
                          agent: proxy(process.env.AWS_PROXY)
                      }
              Severity: Major
              Found in src/KmsUtils.js and 3 other locations - About 55 mins to fix
              src/agent/AgentMetrics.js on lines 33..39
              src/serverless/gtmGithubMetricCapture/gtmGithubMetricCapture.js on lines 18..24
              src/serverless/gtmGithubResults/gtmGithubResults.js on lines 64..70

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  if (process.env.IAM_ENABLED) {
                      AWS.config.update({
                          httpOptions: {
                              agent: PROXY_AGENT(process.env.AWS_PROXY)
                          }
              src/KmsUtils.js on lines 3..9
              src/agent/AgentMetrics.js on lines 33..39
              src/serverless/gtmGithubResults/gtmGithubResults.js on lines 64..70

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

              if (process.env.IAM_ENABLED) {
                  AWS.config.update({
                      httpOptions: {
                          agent: proxy(process.env.HTTP_PROXY)
                      }
              Severity: Major
              Found in src/agent/AgentMetrics.js and 3 other locations - About 55 mins to fix
              src/KmsUtils.js on lines 3..9
              src/serverless/gtmGithubMetricCapture/gtmGithubMetricCapture.js on lines 18..24
              src/serverless/gtmGithubResults/gtmGithubResults.js on lines 64..70

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language