Sign upLogin

zpatten/cucumber-chef

View on GitHub
Star

Showing 32 of 32 total issues

File containers.rb has 317 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'tempfile'

module Cucumber
  module Chef
Severity: Minor
Found in lib/cucumber/chef/containers.rb - About 3 hrs to fix

    Class Containers has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Containers

################################################################################

      def initialize(ui=ZTK::UI.new, test_lab=nil)
    Severity: Minor
    Found in lib/cucumber/chef/containers.rb - About 2 hrs to fix

      Method _create has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def _create(name, distro, release, arch)
        unless exists?(name)
          cache_rootfs = cache_root(name, distro, release, arch)
          if !File.exists?(cache_rootfs)
            @ui.logger.warn { "'#{name}' has triggered building the lxc file cache for '#{distro}'." }
      Severity: Minor
      Found in lib/cucumber/chef/containers.rb - About 1 hr to fix

        Method up has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def up(options={})

        # PUSH CHEF-REPO
        #################
        Severity: Minor
        Found in lib/cucumber/chef/client.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            module Chef

    module Utility
      module LXCHelper
          Severity: Major
          Found in lib/cucumber/chef/utility/lxc_helper.rb and 1 other location - About 1 hr to fix
          lib/cucumber/chef/utility/lab_helper.rb on lines 23..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            module Chef

    module Utility
      module LabHelper
          Severity: Major
          Found in lib/cucumber/chef/utility/lab_helper.rb and 1 other location - About 1 hr to fix
          lib/cucumber/chef/utility/lxc_helper.rb on lines 23..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method locate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

                def locate(type, *args)
        pwd = Dir.pwd.split(File::SEPARATOR)
        (pwd.length - 1).downto(0) do |i|
          candidate = File.join(pwd[0..i], args)
          case type
          Severity: Minor
          Found in lib/cucumber/chef/utility.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method _create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

                def _create(name, distro, release, arch)
        unless exists?(name)
          cache_rootfs = cache_root(name, distro, release, arch)
          if !File.exists?(cache_rootfs)
            @ui.logger.warn { "'#{name}' has triggered building the lxc file cache for '#{distro}'." }
          Severity: Minor
          Found in lib/cucumber/chef/containers.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method chef_config_client has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def chef_config_client(container)
        tempfile = Tempfile.new(container.id)
        client_rb = File.join("/", root(container.id), "etc/chef/client.rb")

        @test_lab.bootstrap_ssh.exec(%(sudo mkdir -pv #{File.dirname(client_rb)}), :silence => true)
          Severity: Minor
          Found in lib/cucumber/chef/containers.rb - About 1 hr to fix

            Method run_feature has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def run_feature(feature_file)
      puts("=" * 80)
      puts("run_feature(#{feature_file.inspect})")
      puts("=" * 80)
            Severity: Minor
            Found in lib/cucumber-chef/rake/task.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def ssh(options={})
        if (!defined?(@ssh) || @ssh.nil?)
          @ssh ||= ZTK::SSH.new({:ui => @ui, :timeout => Cucumber::Chef::Config.command_timeout}.merge(options))

          @ssh.config.host_name = self.ip
            Severity: Major
            Found in lib/cucumber/chef/test_lab.rb and 1 other location - About 1 hr to fix
            lib/cucumber/chef/test_lab.rb on lines 41..50

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def bootstrap_ssh(options={})
        if (!defined?(@bootstrap_ssh) || @bootstrap_ssh.nil?)
          @bootstrap_ssh ||= ZTK::SSH.new({:ui => @ui, :timeout => Cucumber::Chef::Config.command_timeout}.merge(options))

          @bootstrap_ssh.config.host_name = self.ip
            Severity: Major
            Found in lib/cucumber/chef/test_lab.rb and 1 other location - About 1 hr to fix
            lib/cucumber/chef/test_lab.rb on lines 55..64

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method create has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def create(container)
        # if this is a new or non-persistent container destroy it
        destroy(container.id) if !container.persist

        container.ip ||= self.generate_ip
            Severity: Minor
            Found in lib/cucumber/chef/containers.rb - About 1 hr to fix

              Method up has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                      def up
          if (exists? && dead?)
            if @server.start
              @server.wait_for { ready? }
              ZTK::TCPSocketCheck.new(:host => self.ip, :port => self.port, :wait => 120).wait
              Severity: Minor
              Found in lib/cucumber/chef/providers/aws.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                    def create(container)
        # if this is a new or non-persistent container destroy it
        destroy(container.id) if !container.persist

        container.ip ||= self.generate_ip
              Severity: Minor
              Found in lib/cucumber/chef/containers.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method aws_image_id has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                    def self.aws_image_id
        if self[:aws][:aws_image_id]
          return self[:aws][:aws_image_id]
        elsif (self[:aws][:ubuntu_release] && self[:aws][:region])
          ami = Ubuntu.release(self[:aws][:ubuntu_release]).amis.find do |ami|
              Severity: Minor
              Found in lib/cucumber/chef/config.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method ensure_security_group has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                      def ensure_security_group
          security_group_name = Cucumber::Chef::Config.aws[:aws_security_group]
          if (security_group = @connection.security_groups.get(security_group_name))
            port_ranges = security_group.ip_permissions.collect{ |entry| entry["fromPort"]..entry["toPort"] }
            security_group.authorize_port_range(22..22) if port_ranges.none?{ |port_range| port_range === 22 }
              Severity: Minor
              Found in lib/cucumber/chef/providers/aws.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    def method_missing(method_name, *method_args)
        if Cucumber::Chef::Provider::PROXY_METHODS.include?(method_name.to_s)
          result = @provider.send(method_name.to_sym, *method_args)
          splat = [method_name, *method_args].flatten.compact
          @ui.logger.debug { "TestLab: #{splat.inspect}=#{result.inspect}" }
              Severity: Minor
              Found in lib/cucumber/chef/test_lab.rb and 1 other location - About 50 mins to fix
              lib/cucumber/chef/provider.rb on lines 84..91

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    def method_missing(method_name, *method_args)
        if Cucumber::Chef::Provider::PROXY_METHODS.include?(method_name.to_s)
          result = @provider.send(method_name.to_sym, *method_args)
          splat = [method_name, *method_args].flatten.compact
          @ui.logger.debug { "Provider: #{splat.inspect}=#{result.inspect}" }
              Severity: Minor
              Found in lib/cucumber/chef/provider.rb and 1 other location - About 50 mins to fix
              lib/cucumber/chef/test_lab.rb on lines 106..113

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method down has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                      def down
          if (exists? && alive?)
            if !@server.stop
              raise AWSError, "Failed to halt the test lab!"
            end
              Severity: Minor
              Found in lib/cucumber/chef/providers/aws.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language