Sign upLogin

zuzak/gov.zk

View on GitHub
Star

Showing 32 of 32 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (nicks.indexOf(irc[i].nick) === -1) {
      nicks.push(irc[i].nick)
    }
Severity: Minor
Found in routes/login.js and 1 other location - About 40 mins to fix
routes/books.js on lines 72..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (longlistParticipants.indexOf(books[i].longlistedBy) === -1) {
      longlistParticipants.push(books[i].longlistedBy)
    }
Severity: Minor
Found in routes/books.js and 1 other location - About 40 mins to fix
routes/login.js on lines 12..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if (!b[i].status[req.user]) b[i].status[req.user] = []
Severity: Minor
Found in routes/reading.js and 1 other location - About 35 mins to fix
routes/books.js on lines 433..433

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if (!b[i].status[req.user]) b[i].status[req.user] = []
Severity: Minor
Found in routes/books.js and 1 other location - About 35 mins to fix
routes/reading.js on lines 31..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return next()
Severity: Major
Found in routes/auth.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      if (await isFollowing(username, 'countdankulatv')) return { verdict: 'upheld', because: 'the reason you were originally blocked is still true' }
    Severity: Major
    Found in routes/twitter.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return { verdict: 'referred', because: 'you were probably blocked manually' }
      Severity: Major
      Found in routes/twitter.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          if (await isFollowing('zuzakistan', username)) return { verdict: 'overturned', because: 'you have been vouched for' }
        Severity: Major
        Found in routes/twitter.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            if (await isFollowing(username, 'lgballiance')) return { verdict: 'overturned', because: 'you were likely blocked in error' }
          Severity: Major
          Found in routes/twitter.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              if (await isFollowing('lgballiance', username)) return { verdict: 'overturned', because: 'you have been vouched for' }
            Severity: Major
            Found in routes/twitter.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return translation
              Severity: Major
              Found in server.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return __('fallback', { content: translation })
                Severity: Major
                Found in server.js - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language