Sign upLogin

zxing-js/library

View on GitHub
Star
src/core/aztec/encoder/Encoder.ts

Summary

Maintainability
F
3 days
Test Coverage
A
98%

Function encode has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

  public static encode(data: Uint8Array, minECCPercent: int, userSpecifiedLayers: int): AztecCode {
    // High-level encode
    let bits: BitArray = new HighLevelEncoder(data).encode();

    // stuff bits and choose symbol size
Severity: Minor
Found in src/core/aztec/encoder/Encoder.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function drawModeMessage has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

  private static drawModeMessage(matrix: BitMatrix, compact: boolean, matrixSize: int, modeMessage: BitArray): void {
    let center: int = Integer.truncDivision(matrixSize, 2);
    if (compact) {
      for (let i /*int*/ = 0; i < 7; i++) {
        let offset: int = center - 3 + i;
Severity: Minor
Found in src/core/aztec/encoder/Encoder.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function encode has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public static encode(data: Uint8Array, minECCPercent: int, userSpecifiedLayers: int): AztecCode {
    // High-level encode
    let bits: BitArray = new HighLevelEncoder(data).encode();

    // stuff bits and choose symbol size
Severity: Major
Found in src/core/aztec/encoder/Encoder.ts - About 4 hrs to fix

    File Encoder.ts has 254 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import BitArray from '../../common/BitArray';
import IllegalArgumentException from '../../IllegalArgumentException';
import StringUtils from '../../common/StringUtils';
import BitMatrix from '../../common/BitMatrix';
import AztecCode from './AztecCode';
    Severity: Minor
    Found in src/core/aztec/encoder/Encoder.ts - About 2 hrs to fix

      Function drawModeMessage has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private static drawModeMessage(matrix: BitMatrix, compact: boolean, matrixSize: int, modeMessage: BitArray): void {
    let center: int = Integer.truncDivision(matrixSize, 2);
    if (compact) {
      for (let i /*int*/ = 0; i < 7; i++) {
        let offset: int = center - 3 + i;
      Severity: Minor
      Found in src/core/aztec/encoder/Encoder.ts - About 1 hr to fix

        Function stuffBits has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          static stuffBits(bits: BitArray, wordSize: int): BitArray {
    let out: BitArray = new BitArray();

    let n: int = bits.getSize();
    let mask: int = (1 << wordSize) - 2;
        Severity: Minor
        Found in src/core/aztec/encoder/Encoder.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function bitsToWords has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          private static bitsToWords(stuffedBits: BitArray, wordSize: int, totalWords: int): Int32Array {
    let message: Int32Array = new Int32Array(totalWords);
    let i: int;
    let n: int;
    for (i = 0, n = stuffedBits.getSize() / wordSize; i < n; i++) {
        Severity: Minor
        Found in src/core/aztec/encoder/Encoder.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (compact) {
      modeMessage.appendBits(layers - 1, 2);
      modeMessage.appendBits(messageSizeInWords - 1, 6);
      modeMessage = Encoder.generateCheckWords(modeMessage, 28, 4);
    } else {
        Severity: Minor
        Found in src/core/aztec/encoder/Encoder.ts and 1 other location - About 50 mins to fix
        src/core/aztec/encoder/Encoder.ts on lines 238..242

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            } else {
      modeMessage.appendBits(layers - 1, 5);
      modeMessage.appendBits(messageSizeInWords - 1, 11);
      modeMessage = Encoder.generateCheckWords(modeMessage, 40, 4);
    }
        Severity: Minor
        Found in src/core/aztec/encoder/Encoder.ts and 1 other location - About 50 mins to fix
        src/core/aztec/encoder/Encoder.ts on lines 234..238

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status