Sign upLogin

zxing-js/library

View on GitHub
Star
src/core/datamatrix/decoder/BitMatrixParser.ts

Summary

Maintainability
F
1 wk
Test Coverage
A
96%

Function readCodewords has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  readCodewords(): Int8Array {

    const result = new Int8Array(this.version.getTotalCodewords());
    let resultOffset = 0;
Severity: Minor
Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File BitMatrixParser.ts has 303 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import BitMatrix from '../../common/BitMatrix';
import Version from './Version';

import FormatException from '../../FormatException';
import IllegalArgumentException from '../../IllegalArgumentException';
Severity: Minor
Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 3 hrs to fix

    Function readCodewords has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      readCodewords(): Int8Array {

    const result = new Int8Array(this.version.getTotalCodewords());
    let resultOffset = 0;
    Severity: Major
    Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 2 hrs to fix

      Function extractDataRegion has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        private extractDataRegion(bitMatrix: BitMatrix): BitMatrix {
    const symbolSizeRows = this.version.getSymbolSizeRows();
    const symbolSizeColumns = this.version.getSymbolSizeColumns();

    if (bitMatrix.getHeight() !== symbolSizeRows) {
      Severity: Minor
      Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function readCorner4 has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private readCorner4(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 3, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
      Severity: Minor
      Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 1 hr to fix

        Function readCorner1 has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          private readCorner1(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 1, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
        Severity: Minor
        Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 1 hr to fix

          Function readCorner2 has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            private readCorner2(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 3, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
          Severity: Minor
          Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 1 hr to fix

            Function readCorner3 has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              private readCorner3(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 1, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
            Severity: Minor
            Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 1 hr to fix

              Function readUtah has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                private readUtah(row: number, column: number, numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(row - 2, column - 2, numRows, numColumns)) {
      currentByte |= 1;
    }
              Severity: Minor
              Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 1 hr to fix

                Function extractDataRegion has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  private extractDataRegion(bitMatrix: BitMatrix): BitMatrix {
    const symbolSizeRows = this.version.getSymbolSizeRows();
    const symbolSizeColumns = this.version.getSymbolSizeColumns();

    if (bitMatrix.getHeight() !== symbolSizeRows) {
                Severity: Minor
                Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 1 hr to fix

                  Function readCorner3 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                    private readCorner3(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 1, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
                  Severity: Minor
                  Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                              if (bitMatrix.get(readColumnOffset, readRowOffset)) {
              const writeColumnOffset = dataRegionColumnOffset + j;
              bitMatrixWithoutAlignment.set(writeColumnOffset, writeRowOffset);
            }
                  Severity: Major
                  Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 45 mins to fix

                    Function readCorner1 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      private readCorner1(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 1, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
                    Severity: Minor
                    Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function readCorner4 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      private readCorner4(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 3, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
                    Severity: Minor
                    Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function readCorner2 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      private readCorner2(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 3, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
                    Severity: Minor
                    Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function readUtah has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      private readUtah(row: number, column: number, numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(row - 2, column - 2, numRows, numColumns)) {
      currentByte |= 1;
    }
                    Severity: Minor
                    Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Consider simplifying this complex logical expression.
                    Open

                          } else if ((row === numRows - 2) && (column === 0) && ((numColumns & 0x07) === 4) && !corner4Read) {
        result[resultOffset++] = this.readCorner4(numRows, numColumns) & 0xff;
        row -= 2;
        column += 2;
        corner4Read = true;
                    Severity: Major
                    Found in src/core/datamatrix/decoder/BitMatrixParser.ts - About 40 mins to fix

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                        private readCorner2(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 3, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
                      Severity: Major
                      Found in src/core/datamatrix/decoder/BitMatrixParser.ts and 2 other locations - About 1 day to fix
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 225..259
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 360..394

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 317.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                        private readCorner4(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 3, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
                      Severity: Major
                      Found in src/core/datamatrix/decoder/BitMatrixParser.ts and 2 other locations - About 1 day to fix
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 225..259
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 270..304

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 317.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                        private readCorner1(numRows: number, numColumns: number): number {
    let currentByte = 0;
    if (this.readModule(numRows - 1, 0, numRows, numColumns)) {
      currentByte |= 1;
    }
                      Severity: Major
                      Found in src/core/datamatrix/decoder/BitMatrixParser.ts and 2 other locations - About 1 day to fix
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 270..304
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 360..394

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 317.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                            } else if ((row === numRows - 2) && (column === 0) && ((numColumns & 0x07) === 4) && !corner4Read) {
        result[resultOffset++] = this.readCorner4(numRows, numColumns) & 0xff;
        row -= 2;
        column += 2;
        corner4Read = true;
                      Severity: Major
                      Found in src/core/datamatrix/decoder/BitMatrixParser.ts and 3 other locations - About 50 mins to fix
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 95..137
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 100..137
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 105..137

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 51.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                            if ((row === numRows) && (column === 0) && !corner1Read) {
        result[resultOffset++] = this.readCorner1(numRows, numColumns) & 0xff;
        row -= 2;
        column += 2;
        corner1Read = true;
                      Severity: Major
                      Found in src/core/datamatrix/decoder/BitMatrixParser.ts and 3 other locations - About 50 mins to fix
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 100..137
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 105..137
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 110..137

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 51.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                            } else if ((row === numRows - 2) && (column === 0) && ((numColumns & 0x03) !== 0) && !corner2Read) {
        result[resultOffset++] = this.readCorner2(numRows, numColumns) & 0xff;
        row -= 2;
        column += 2;
        corner2Read = true;
                      Severity: Major
                      Found in src/core/datamatrix/decoder/BitMatrixParser.ts and 3 other locations - About 50 mins to fix
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 95..137
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 105..137
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 110..137

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 51.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                            } else if ((row === numRows + 4) && (column === 2) && ((numColumns & 0x07) === 0) && !corner3Read) {
        result[resultOffset++] = this.readCorner3(numRows, numColumns) & 0xff;
        row -= 2;
        column += 2;
        corner3Read = true;
                      Severity: Major
                      Found in src/core/datamatrix/decoder/BitMatrixParser.ts and 3 other locations - About 50 mins to fix
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 95..137
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 100..137
                      src/core/datamatrix/decoder/BitMatrixParser.ts on lines 110..137

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 51.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status