Sign upLogin

zxing-js/library

View on GitHub
Star
src/core/datamatrix/encoder/C40Encoder.ts

Summary

Maintainability
D
2 days
Test Coverage

Function handleEOD has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  handleEOD(context: EncoderContext, buffer: StringBuilder): void {
    const unwritten = Math.floor((buffer.length() / 3) * 2);
    const rest = buffer.length() % 3;

    const curCodewordCount = context.getCodewordCount() + unwritten;
Severity: Minor
Found in src/core/datamatrix/encoder/C40Encoder.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function encode has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  public encode(context: EncoderContext): void {
    // step C
    const buffer = new StringBuilder();
    while (context.hasMoreCharacters()) {
      const c = context.getCurrentChar();
Severity: Minor
Found in src/core/datamatrix/encoder/C40Encoder.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function encode has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public encode(context: EncoderContext): void {
    // step C
    const buffer = new StringBuilder();
    while (context.hasMoreCharacters()) {
      const c = context.getCurrentChar();
Severity: Minor
Found in src/core/datamatrix/encoder/C40Encoder.ts - About 1 hr to fix

    Function encodeChar has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      encodeChar(c: char, sb: StringBuilder): number {
    if (c === ' '.charCodeAt(0)) {
      sb.append(0o3);
      return 1;
    }
    Severity: Minor
    Found in src/core/datamatrix/encoder/C40Encoder.ts - About 1 hr to fix

      Function handleEOD has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        handleEOD(context: EncoderContext, buffer: StringBuilder): void {
    const unwritten = Math.floor((buffer.length() / 3) * 2);
    const rest = buffer.length() % 3;

    const curCodewordCount = context.getCodewordCount() + unwritten;
      Severity: Minor
      Found in src/core/datamatrix/encoder/C40Encoder.ts - About 1 hr to fix

        Function encodeMaximal has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          encodeMaximal(context: EncoderContext): void {
    const buffer = new StringBuilder();
    let lastCharSize = 0;
    let backtrackStartPosition = context.pos;
    let backtrackBufferLength = 0;
        Severity: Minor
        Found in src/core/datamatrix/encoder/C40Encoder.ts - About 1 hr to fix

          Function encodeMaximal has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            encodeMaximal(context: EncoderContext): void {
    const buffer = new StringBuilder();
    let lastCharSize = 0;
    let backtrackStartPosition = context.pos;
    let backtrackBufferLength = 0;
          Severity: Minor
          Found in src/core/datamatrix/encoder/C40Encoder.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function encodeChar has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            encodeChar(c: char, sb: StringBuilder): number {
    if (c === ' '.charCodeAt(0)) {
      sb.append(0o3);
      return 1;
    }
          Severity: Minor
          Found in src/core/datamatrix/encoder/C40Encoder.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                return 2;
          Severity: Major
          Found in src/core/datamatrix/encoder/C40Encoder.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return len;
            Severity: Major
            Found in src/core/datamatrix/encoder/C40Encoder.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return 2;
              Severity: Major
              Found in src/core/datamatrix/encoder/C40Encoder.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return 2;
                Severity: Major
                Found in src/core/datamatrix/encoder/C40Encoder.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return 2;
                  Severity: Major
                  Found in src/core/datamatrix/encoder/C40Encoder.ts - About 30 mins to fix

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        if (c >= '0'.charCodeAt(0) && c <= '9'.charCodeAt(0)) {
      sb.append(c - 48 + 4);
      return 1;
    }
                    Severity: Major
                    Found in src/core/datamatrix/encoder/C40Encoder.ts and 3 other locations - About 1 hr to fix
                    src/core/datamatrix/encoder/C40Encoder.ts on lines 207..210
                    src/core/datamatrix/encoder/TextEncoder.ts on lines 16..19
                    src/core/datamatrix/encoder/TextEncoder.ts on lines 20..23

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 57.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        if (c >= 'A'.charCodeAt(0) && c <= 'Z'.charCodeAt(0)) {
      sb.append(c - 65 + 14);
      return 1;
    }
                    Severity: Major
                    Found in src/core/datamatrix/encoder/C40Encoder.ts and 3 other locations - About 1 hr to fix
                    src/core/datamatrix/encoder/C40Encoder.ts on lines 203..206
                    src/core/datamatrix/encoder/TextEncoder.ts on lines 16..19
                    src/core/datamatrix/encoder/TextEncoder.ts on lines 20..23

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 57.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        if (c <= '_'.charCodeAt(0)) {
      sb.append(0o1); // Shift 2 Set
      sb.append(c - 91 + 22);
      return 2;
    }
                    Severity: Major
                    Found in src/core/datamatrix/encoder/C40Encoder.ts and 3 other locations - About 1 hr to fix
                    src/core/datamatrix/encoder/C40Encoder.ts on lines 221..225
                    src/core/datamatrix/encoder/TextEncoder.ts on lines 34..38
                    src/core/datamatrix/encoder/TextEncoder.ts on lines 49..53

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        if (c <= '@'.charCodeAt(0)) {
      sb.append(0o1); // Shift 2 Set
      sb.append(c - 58 + 15);
      return 2;
    }
                    Severity: Major
                    Found in src/core/datamatrix/encoder/C40Encoder.ts and 3 other locations - About 1 hr to fix
                    src/core/datamatrix/encoder/C40Encoder.ts on lines 226..230
                    src/core/datamatrix/encoder/TextEncoder.ts on lines 34..38
                    src/core/datamatrix/encoder/TextEncoder.ts on lines 49..53

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (c <= '/'.charCodeAt(0)) {
      sb.append(0o1); // Shift 2 Set
      sb.append(c - 33);
      return 2;
    }
                    Severity: Minor
                    Found in src/core/datamatrix/encoder/C40Encoder.ts and 1 other location - About 50 mins to fix
                    src/core/datamatrix/encoder/TextEncoder.ts on lines 29..33

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 52.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (c < ' '.charCodeAt(0)) {
      sb.append(0o0); // Shift 1 Set
      sb.append(c);
      return 2;
    }
                    Severity: Minor
                    Found in src/core/datamatrix/encoder/C40Encoder.ts and 1 other location - About 40 mins to fix
                    src/core/datamatrix/encoder/TextEncoder.ts on lines 24..28

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 48.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status