Sign upLogin

zxing-js/library

View on GitHub
Star
src/core/oned/Code128Reader.ts

Summary

Maintainability
F
1 wk
Test Coverage
B
87%

Function decodeRow has a Cognitive Complexity of 130 (exceeds 5 allowed). Consider refactoring.
Open

  public decodeRow(rowNumber: number, row: BitArray, hints?: Map<DecodeHintType, any>): Result {
    const convertFNC1 = hints && (hints.get(DecodeHintType.ASSUME_GS1) === true);

    const startPatternInfo = Code128Reader.findStartPattern(row);
    const startCode = startPatternInfo[2];
Severity: Minor
Found in src/core/oned/Code128Reader.ts - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function decodeRow has 234 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public decodeRow(rowNumber: number, row: BitArray, hints?: Map<DecodeHintType, any>): Result {
    const convertFNC1 = hints && (hints.get(DecodeHintType.ASSUME_GS1) === true);

    const startPatternInfo = Code128Reader.findStartPattern(row);
    const startCode = startPatternInfo[2];
Severity: Major
Found in src/core/oned/Code128Reader.ts - About 1 day to fix

    File Code128Reader.ts has 430 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright 2008 ZXing authors
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
    Severity: Minor
    Found in src/core/oned/Code128Reader.ts - About 6 hrs to fix

      Function findStartPattern has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

        private static findStartPattern(row: BitArray): Int32Array {
    const width = row.getSize();
    const rowOffset = row.getNextSet(0);

        let counterPosition = 0;
      Severity: Minor
      Found in src/core/oned/Code128Reader.ts - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function findStartPattern has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private static findStartPattern(row: BitArray): Int32Array {
    const width = row.getSize();
    const rowOffset = row.getNextSet(0);

        let counterPosition = 0;
      Severity: Minor
      Found in src/core/oned/Code128Reader.ts - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                        if (convertFNC1) {
                  if (result.length === 0) {
                    // GS1 specification 5.4.3.7. and 5.4.6.4. If the first char after the start code
                    // is FNC1 then this is GS1-128. We add the symbology identifier.
                    result += ']C1';
        Severity: Major
        Found in src/core/oned/Code128Reader.ts - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                          if (convertFNC1) {
                  if (result.length === 0) {
                    // GS1 specification 5.4.3.7. and 5.4.6.4. If the first char after the start code
                    // is FNC1 then this is GS1-128. We add the symbology identifier.
                    result += ']C1';
          Severity: Major
          Found in src/core/oned/Code128Reader.ts - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        switch (code) {
              case Code128Reader.CODE_FNC_1:
                if (convertFNC1) {
                  if (result.length === 0) {
                    // GS1 specification 5.4.3.7. and 5.4.6.4. If the first char after the start code
            Severity: Major
            Found in src/core/oned/Code128Reader.ts - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                              if (!upperMode && shiftUpperMode) {
                  upperMode = true;
                  shiftUpperMode = false;
                } else if (upperMode && shiftUpperMode) {
                  upperMode = false;
              Severity: Major
              Found in src/core/oned/Code128Reader.ts - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                            if (variance < bestVariance) {
              bestVariance = variance;
              bestMatch = startCode;
            }
                Severity: Major
                Found in src/core/oned/Code128Reader.ts - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                              if (shiftUpperMode === upperMode) {
              result += String.fromCharCode((code - 64));
            } else {
              result += String.fromCharCode((code + 64));
            }
                  Severity: Major
                  Found in src/core/oned/Code128Reader.ts - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                if (code !== Code128Reader.CODE_STOP) {
              lastCharacterWasPrintable = false;
            }
                    Severity: Major
                    Found in src/core/oned/Code128Reader.ts - About 45 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  switch (code) {
              case Code128Reader.CODE_FNC_1:
                if (convertFNC1) {
                  if (result.length === 0) {
                    // GS1 specification 5.4.3.7. and 5.4.6.4. If the first char after the start code
                      Severity: Major
                      Found in src/core/oned/Code128Reader.ts and 1 other location - About 1 day to fix
                      src/core/oned/Code128Reader.ts on lines 393..434

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 241.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  switch (code) {
              case Code128Reader.CODE_FNC_1:
                if (convertFNC1) {
                  if (result.length === 0) {
                    // GS1 specification 5.4.3.7. and 5.4.6.4. If the first char after the start code
                      Severity: Major
                      Found in src/core/oned/Code128Reader.ts and 1 other location - About 1 day to fix
                      src/core/oned/Code128Reader.ts on lines 337..378

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 241.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                if (code < 64) {
            if (shiftUpperMode === upperMode) {
              result += String.fromCharCode((' '.charCodeAt(0) + code));
            } else {
              result += String.fromCharCode((' '.charCodeAt(0) + code + 128));
                      Severity: Major
                      Found in src/core/oned/Code128Reader.ts and 1 other location - About 2 hrs to fix
                      src/core/oned/Code128Reader.ts on lines 382..435

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 84.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                if (code < 96) {
            if (shiftUpperMode === upperMode) {
              result += String.fromCharCode((' '.charCodeAt(0) + code));
            } else {
              result += String.fromCharCode((' '.charCodeAt(0) + code + 128));
                      Severity: Major
                      Found in src/core/oned/Code128Reader.ts and 1 other location - About 2 hrs to fix
                      src/core/oned/Code128Reader.ts on lines 317..379

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 84.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status