Sign upLogin

zxing-js/library

View on GitHub
Star
src/core/qrcode/decoder/DecodedBitStreamParser.ts

Summary

Maintainability
D
1 day
Test Coverage
D
67%

Function decode has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public static decode(bytes: Uint8Array,
    version: Version,
    ecLevel: ErrorCorrectionLevel,
    hints: Map<DecodeHintType, any>): DecoderResult /*throws FormatException*/ {
    const bits = new BitSource(bytes);
Severity: Major
Found in src/core/qrcode/decoder/DecodedBitStreamParser.ts - About 2 hrs to fix

    Function decode has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

      public static decode(bytes: Uint8Array,
    version: Version,
    ecLevel: ErrorCorrectionLevel,
    hints: Map<DecodeHintType, any>): DecoderResult /*throws FormatException*/ {
    const bits = new BitSource(bytes);
    Severity: Minor
    Found in src/core/qrcode/decoder/DecodedBitStreamParser.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function decodeAlphanumericSegment has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      private static decodeAlphanumericSegment(bits: BitSource,
    result: StringBuilder,
    count: number /*int*/,
    fc1InEffect: boolean): void /*throws FormatException*/ {
    // Read two characters at a time
    Severity: Minor
    Found in src/core/qrcode/decoder/DecodedBitStreamParser.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function decodeNumericSegment has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      private static decodeNumericSegment(bits: BitSource,
    result: StringBuilder,
    count: number /*int*/): void /*throws FormatException*/ {
    // Read three digits at a time
    while (count >= 3) {
    Severity: Minor
    Found in src/core/qrcode/decoder/DecodedBitStreamParser.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function decodeNumericSegment has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private static decodeNumericSegment(bits: BitSource,
    result: StringBuilder,
    count: number /*int*/): void /*throws FormatException*/ {
    // Read three digits at a time
    while (count >= 3) {
    Severity: Minor
    Found in src/core/qrcode/decoder/DecodedBitStreamParser.ts - About 1 hr to fix

      Function decodeAlphanumericSegment has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private static decodeAlphanumericSegment(bits: BitSource,
    result: StringBuilder,
    count: number /*int*/,
    fc1InEffect: boolean): void /*throws FormatException*/ {
    // Read two characters at a time
      Severity: Minor
      Found in src/core/qrcode/decoder/DecodedBitStreamParser.ts - About 1 hr to fix

        Function decodeKanjiSegment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          private static decodeKanjiSegment(bits: BitSource,
    result: StringBuilder,
    count: number /*int*/): void /*throws FormatException*/ {
    // Don't crash trying to read more bits than we have available.
    if (count * 13 > bits.available()) {
        Severity: Minor
        Found in src/core/qrcode/decoder/DecodedBitStreamParser.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function decodeHanziSegment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          private static decodeHanziSegment(bits: BitSource,
    result: StringBuilder,
    count: number /*int*/): void /*throws FormatException*/ {
    // Don't crash trying to read more bits than we have available.
    if (count * 13 > bits.available()) {
        Severity: Minor
        Found in src/core/qrcode/decoder/DecodedBitStreamParser.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if ((firstByte & 0xC0) === 0x80) {
      // two bytes
      const secondByte = bits.readBits(8);
      return (((firstByte & 0x3F) << 8) & 0xFFFFFFFF) | secondByte;
    }
        Severity: Minor
        Found in src/core/qrcode/decoder/DecodedBitStreamParser.ts and 1 other location - About 50 mins to fix
        src/core/qrcode/decoder/DecodedBitStreamParser.ts on lines 359..363

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if ((firstByte & 0xE0) === 0xC0) {
      // three bytes
      const secondThirdBytes = bits.readBits(16);
      return (((firstByte & 0x1F) << 16) & 0xFFFFFFFF) | secondThirdBytes;
    }
        Severity: Minor
        Found in src/core/qrcode/decoder/DecodedBitStreamParser.ts and 1 other location - About 50 mins to fix
        src/core/qrcode/decoder/DecodedBitStreamParser.ts on lines 354..358

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status