Sign upLogin

18F/Paid-Leave-Prototype

View on GitHub
Star

Showing 398 of 398 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    var end_date_formatted = monthNames[date.getMonth()] + " " + date.getUTCDate() + ", " + date.getUTCFullYear();
Severity: Minor
Found in javascripts/estimator.js and 1 other location - About 35 mins to fix
javascripts/estimator.js on lines 21..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    var start_date_formatted = monthNames[date.getMonth()] + " " + date.getUTCDate() + ", " + date.getUTCFullYear();
Severity: Minor
Found in javascripts/estimator.js and 1 other location - About 35 mins to fix
javascripts/estimator.js on lines 17..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Rule doesn't have all its properties in alphabetical order.
Open

.layout-claims-new main h1{
Severity: Minor
Found in stylesheets/form.css by csslint

Heading (h3) should not be qualified.
Open

.layout-claims-new form h3,
Severity: Minor
Found in stylesheets/form.css by csslint

Adjoining classes: .relationship.type .controls::after
Open

.relationship.type .controls::after,
Severity: Minor
Found in stylesheets/form.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.controls label.radio input{
Severity: Minor
Found in stylesheets/form.css by csslint

Adjoining classes: .field.field-state
Open

.field.field-state,
Severity: Minor
Found in stylesheets/form.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.a-skip-to-main {
Severity: Minor
Found in stylesheets/screen.css by csslint

Heading (h5) has already been defined.
Open

.page h5 {
Severity: Minor
Found in stylesheets/screen.css by csslint

Heading (h2) should not be qualified.
Open

.layout-home .overview h2 {
Severity: Minor
Found in stylesheets/screen.css by csslint

Heading (h3) has already been defined.
Open

    .page h3,
Severity: Minor
Found in stylesheets/screen.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.field .help-text,
Severity: Minor
Found in stylesheets/form.css by csslint

Adjoining classes: .fieldset-name .field.field-name-last
Open

.fieldset-name .field.field-name-last{ margin-right: 0; }
Severity: Minor
Found in stylesheets/form.css by csslint

Adjoining classes: .field.field-city
Open

.field.field-city,
Severity: Minor
Found in stylesheets/form.css by csslint

Using height with border can sometimes make elements larger than you expect.
Open

        border: 1px solid #888;
Severity: Minor
Found in stylesheets/form.css by csslint

The universal selector (*) is known to be slow.
Open

*:after {
Severity: Minor
Found in stylesheets/screen.css by csslint

Heading (h3) should not be qualified.
Open

.page h3,
Severity: Minor
Found in stylesheets/screen.css by csslint

Heading (h4) should not be qualified.
Open

.page h4,
Severity: Minor
Found in stylesheets/screen.css by csslint

Heading (h2) has already been defined.
Open

    .page h2,
Severity: Minor
Found in stylesheets/screen.css by csslint

Heading (h3) should not be qualified.
Open

    .page h3,
Severity: Minor
Found in stylesheets/screen.css by csslint
Severity
Category
Status
Source
Language