Showing 398 of 398 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
var start_date_formatted = monthNames[date.getMonth()] + " " + date.getUTCDate() + ", " + date.getUTCFullYear();
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 47.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
var end_date_formatted = monthNames[date.getMonth()] + " " + date.getUTCDate() + ", " + date.getUTCFullYear();
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 47.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Adjoining classes: .fieldset-name .field.field-name-last Open
.fieldset-name .field.field-name-last{ margin-right: 0; }
- Exclude checks
Adjoining classes: .control-group.country Open
.control-group.country,
- Exclude checks
Heading (h1) has already been defined. Open
.layout-claims-new main > .wrapper > h1{ font-size: 36px; }
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
html {
- Exclude checks
The universal selector (*) is known to be slow. Open
*,
- Exclude checks
The universal selector (*) is known to be slow. Open
*:before,
- Exclude checks
Heading (h2) should not be qualified. Open
.page h2,
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
.page h1 span.article,
- Exclude checks
Heading (h1) has already been defined. Open
.page h1,
- Exclude checks
Heading (h4) has already been defined. Open
.page h4 {
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
.layout-claims-new form > div > button,
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
.layout-claims-new h2::after{
- Exclude checks
Adjoining classes: .control-group.zip Open
.control-group.zip,
- Exclude checks
Heading (h1) should not be qualified. Open
.layout-claims-new main > .wrapper > h1{ font-size: 36px; }
- Exclude checks
Heading (h1) has already been defined. Open
.layout-claims-new aside h1{
- Exclude checks
Using width with border can sometimes make elements larger than you expect. Open
border: 1px solid #888;
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
.a-skip-to-main {
- Exclude checks
Heading (h1) should not be qualified. Open
.page h1,
- Exclude checks