Sign upLogin

18F/micropurchase

View on GitHub
Star

Showing 122 of 122 total issues

Merge rule drawer form with rule on line 3
Open

drawer form {
Severity: Minor
Found in app/assets/stylesheets/components/_drawer.scss by scss-lint

Avoid using id selectors
Open

drawer[aria-hidden=false],
Severity: Minor
Found in app/assets/stylesheets/components/_drawer.scss by scss-lint

Method Swagger::Path#operations is defined at both lib/swagger/path.rb:4 and lib/swagger/path.rb:12.
Open

  def operations
Severity: Minor
Found in lib/swagger/path.rb by rubocop

This cop checks for duplicated instance (or singleton) method definitions.

Example:

# bad

def duplicated
  1
end

def duplicated
  2
end

Example:

# bad

def duplicated
  1
end

alias duplicated other_duplicated

Example:

# good

def duplicated
  1
end

def other_duplicated
  2
end

Use %i or %I for an array of symbols.
Open

        resource '*', headers: :any, methods: [:get, :put, :post, :options]
Severity: Minor
Found in config/application.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

'date' is already defined.
Open

      date;
Severity: Minor
Found in app/assets/javascripts/utility.js by eslint

disallow variable redeclaration (no-redeclare)

In JavaScript, it's possible to redeclare the same variable name using var. This can lead to confusion as to where the variable is actually declared and initialized.

Rule Details

This rule is aimed at eliminating variables that have multiple declarations in the same scope.

Examples of incorrect code for this rule:

/*eslint no-redeclare: "error"*/

var a = 3;
var a = 10;

Examples of correct code for this rule:

/*eslint no-redeclare: "error"*/

var a = 3;
// ...
a = 10;

Options

This rule takes one optional argument, an object with a boolean property "builtinGlobals". It defaults to false. If set to true, this rule also checks redeclaration of built-in globals, such as Object, Array, Number...

builtinGlobals

Examples of incorrect code for the { "builtinGlobals": true } option:

/*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/

var Object = 0;

Examples of incorrect code for the { "builtinGlobals": true } option and the browser environment:

/*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
/*eslint-env browser*/

var top = 0;

The browser environment has many built-in global variables (for example, top). Some of built-in global variables cannot be redeclared. Source: http://eslint.org/docs/rules/

Avoid vendor prefixes.
Open

  -ms-justify-content: space-between;
Severity: Minor
Found in app/assets/stylesheets/components/_auctions-index.scss by scss-lint

Avoid qualifying attribute selectors with an element.
Open

drawer[aria-hidden=false],
Severity: Minor
Found in app/assets/stylesheets/components/_drawer.scss by scss-lint

Color #00CFFF should be written as #00cfff
Open

$branding-bright: #00CFFF;
Severity: Minor
Found in app/assets/stylesheets/core/_variables.scss by scss-lint

%w-literals should be delimited by [ and ].
Open

Rails.application.config.assets.precompile += %w(jquery.js admin.js)
Severity: Minor
Found in config/initializers/assets.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Shorthands of length 3 are not allowed. Value was 48px 12px 12px
Open

  padding: 48px 12px 12px;
Severity: Minor
Found in app/assets/stylesheets/components/_docs.scss by scss-lint

Avoid qualifying attribute selectors with an element.
Open

drawer button[data-drawer-toggle="menu"],
Severity: Minor
Found in app/assets/stylesheets/components/_drawer.scss by scss-lint

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem byebug should appear before poltergeist.
Open

  gem 'byebug'
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

Use %i or %I for an array of symbols.
Open

  match 'auth/saml/logout', to: 'saml_authentications#destroy', via: [:get, :post, :delete]
Severity: Minor
Found in config/routes.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Method Swagger::Reference#name is defined at both lib/swagger/reference.rb:3 and lib/swagger/reference.rb:28.
Open

  def name
Severity: Minor
Found in lib/swagger/reference.rb by rubocop

This cop checks for duplicated instance (or singleton) method definitions.

Example:

# bad

def duplicated
  1
end

def duplicated
  2
end

Example:

# bad

def duplicated
  1
end

alias duplicated other_duplicated

Example:

# good

def duplicated
  1
end

def other_duplicated
  2
end

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem apivore should appear before jasmine.
Open

  gem 'apivore'
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

Use %i or %I for an array of symbols.
Open

  match 'auth/saml/callback', to: 'saml_authentications#create', via: [:get, :post]
Severity: Minor
Found in config/routes.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Use %i or %I for an array of symbols.
Open

    resources :receipts, only: [:new, :create]
Severity: Minor
Found in config/routes.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Avoid qualifying attribute selectors with an element.
Open

  input[type="submit"] {
Severity: Minor
Found in app/assets/stylesheets/components/_auction-form.scss by scss-lint

Avoid qualifying attribute selectors with an element.
Open

  button[data-drawer-toggle="menu"] {
Severity: Minor
Found in app/assets/stylesheets/components/_drawer.scss by scss-lint

%w-literals should be delimited by [ and ].
Open

  validates :payment_url, url: { allow_blank: true, no_local: true, schemes: %w(http https) }
Severity: Minor
Found in app/models/user.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)
Severity
Category
Status
Source
Language