Sign upLogin

1ma/UMAPsr7HmacBundle

View on GitHub
Star
src/Security/Firewall/HmacListener.php

Summary

Maintainability
A
35 mins
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($apiKeyHeader, AuthenticationManagerInterface $authManager, TokenStorageInterface $tokenStorage, AuthenticationEntryPointInterface $entryPoint = null, LoggerInterface $logger = null)
Severity: Minor
Found in src/Security/Firewall/HmacListener.php - About 35 mins to fix

    Avoid assigning values to variables in if clauses and the like (line '67', column '26').
    Open

        public function handle(GetResponseEvent $event)
    {
        $request = $event->getRequest();

        try {
    Severity: Minor
    Found in src/Security/Firewall/HmacListener.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    There are no issues that match your filters.

    Category
    Status