3den/riotjs-todomvc

View on GitHub

Showing 130 of 130 total issues

Function domManip has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    domManip: function( args, callback ) {

        // Flatten any nested arrays
        args = concat.apply( [], args );

Severity: Major
Found in bower_components/jquery/dist/jquery.js - About 2 hrs to fix

    Function init has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        init = jQuery.fn.init = function( selector, context ) {
            var match, elem;
    
            // HANDLE: $(""), $(null), $(undefined), $(false)
            if ( !selector ) {
    Severity: Major
    Found in bower_components/jquery/dist/jquery.js - About 2 hrs to fix

      Function Todo has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function Todo() {
          var self = riot.observable(this),
              db = DB('riot-todo'),
              items = db.get();
      
      
      Severity: Major
      Found in js/models/todo.js - About 2 hrs to fix

        Function ajaxConvert has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function ajaxConvert( s, response, jqXHR, isSuccess ) {
            var conv2, current, conv, tmp, prev,
                converters = {},
                // Work with a copy of dataTypes in case we need to modify it for conversion
                dataTypes = s.dataTypes.slice();
        Severity: Major
        Found in bower_components/jquery/dist/jquery.js - About 2 hrs to fix

          Function data has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              data: function( key, value ) {
                  var i, name, data,
                      elem = this[ 0 ],
                      attrs = elem && elem.attributes;
          
          
          Severity: Major
          Found in bower_components/jquery/dist/jquery.js - About 2 hrs to fix

            Function send has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        send: function( headers, complete ) {
                            var i,
                                xhr = options.xhr(),
                                id = ++xhrId;
            
            
            Severity: Major
            Found in bower_components/jquery/dist/jquery.js - About 2 hrs to fix

              Function remove has 50 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  remove: function( elem, types, handler, selector, mappedTypes ) {
              
                      var j, origCount, tmp,
                          events, t, handleObj,
                          special, handlers, type, namespaces, origType,
              Severity: Minor
              Found in bower_components/jquery/dist/jquery.js - About 2 hrs to fix

                Consider simplifying this complex logical expression.
                Open

                                if ( ( mappedTypes || origType === handleObj.origType ) &&
                                    ( !handler || handler.guid === handleObj.guid ) &&
                                    ( !tmp || tmp.test( handleObj.namespace ) ) &&
                                    ( !selector || selector === handleObj.selector || selector === "**" && handleObj.selector ) ) {
                                    handlers.splice( j, 1 );
                Severity: Critical
                Found in bower_components/jquery/dist/jquery.js - About 2 hrs to fix

                  Function buildFragment has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      buildFragment: function( elems, context, scripts, selection ) {
                          var elem, tmp, tag, wrap, contains, j,
                              fragment = context.createDocumentFragment(),
                              nodes = [],
                              i = 0,
                  Severity: Minor
                  Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

                    Function select has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    select = Sizzle.select = function( selector, context, results, seed ) {
                        var i, tokens, token, type, find,
                            compiled = typeof selector === "function" && selector,
                            match = !seed && tokenize( (selector = compiled.selector || selector) );
                    
                    
                    Severity: Minor
                    Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

                      Function tokenize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      tokenize = Sizzle.tokenize = function( selector, parseOnly ) {
                          var matched, match, tokens, type,
                              soFar, groups, preFilters,
                              cached = tokenCache[ selector + " " ];
                      
                      
                      Severity: Minor
                      Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        event.pageY = original.clientY + ( doc && doc.scrollTop  || body && body.scrollTop  || 0 ) - ( doc && doc.clientTop  || body && body.clientTop  || 0 );
                        Severity: Major
                        Found in bower_components/jquery/dist/jquery.js and 1 other location - About 1 hr to fix
                        bower_components/jquery/dist/jquery.js on lines 4505..4505

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 71.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        event.pageX = original.clientX + ( doc && doc.scrollLeft || body && body.scrollLeft || 0 ) - ( doc && doc.clientLeft || body && body.clientLeft || 0 );
                        Severity: Major
                        Found in bower_components/jquery/dist/jquery.js and 1 other location - About 1 hr to fix
                        bower_components/jquery/dist/jquery.js on lines 4506..4506

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 71.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function matcherFromTokens has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function matcherFromTokens( tokens ) {
                            var checkContext, matcher, j,
                                len = tokens.length,
                                leadingRelative = Expr.relative[ tokens[0].type ],
                                implicitRelative = leadingRelative || Expr.relative[" "],
                        Severity: Minor
                        Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

                          Function observable has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          riot.observable = function(el) {
                            var callbacks = {}, slice = [].slice;
                          
                            el.on = function(events, fn) {
                              if (typeof fn === "function") {
                          Severity: Minor
                          Found in bower_components/riotjs/riot.js - About 1 hr to fix

                            Function template has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    _.template = function(text, data, settings) {
                                        var render;
                                        settings = _.defaults({}, settings, _.templateSettings);
                            
                                        // Combine delimiters into one regular expression via alternation.
                            Severity: Minor
                            Found in bower_components/todomvc-common/base.js - About 1 hr to fix

                              Function val has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  val: function( value ) {
                                      var hooks, ret, isFunction,
                                          elem = this[0];
                              
                                      if ( !arguments.length ) {
                              Severity: Minor
                              Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

                                Function on has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    on: function( types, selector, data, fn, /*INTERNAL*/ one ) {
                                        var origFn, type;
                                
                                        // Types can be a map of types/handlers
                                        if ( typeof types === "object" ) {
                                Severity: Minor
                                Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

                                  Function extend has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                  jQuery.extend = jQuery.fn.extend = function() {
                                      var options, name, src, copy, copyIsArray, clone,
                                          target = arguments[0] || {},
                                          i = 1,
                                          length = arguments.length,
                                  Severity: Minor
                                  Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

                                    Function stop has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        stop: function( type, clearQueue, gotoEnd ) {
                                            var stopQueue = function( hooks ) {
                                                var stop = hooks.stop;
                                                delete hooks.stop;
                                                stop( gotoEnd );
                                    Severity: Minor
                                    Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language