Sign upLogin

3den/riotjs-todomvc

View on GitHub
Star

Showing 130 of 130 total issues

Function finish has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    finish: function( type ) {
        if ( type !== false ) {
            type = type || "fx";
        }
        return this.each(function() {
Severity: Minor
Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        preventDefault: function() {
        var e = this.originalEvent;

        this.isDefaultPrevented = returnTrue;
    Severity: Major
    Found in bower_components/jquery/dist/jquery.js and 1 other location - About 1 hr to fix
    bower_components/jquery/dist/jquery.js on lines 4695..4703

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        stopPropagation: function() {
        var e = this.originalEvent;

        this.isPropagationStopped = returnTrue;
    Severity: Major
    Found in bower_components/jquery/dist/jquery.js and 1 other location - About 1 hr to fix
    bower_components/jquery/dist/jquery.js on lines 4686..4694

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function propFilter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function propFilter( props, specialEasing ) {
    var index, name, easing, value, hooks;

    // camelCase, specialEasing and expand cssHook pass
    for ( index in props ) {
    Severity: Minor
    Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

      Function fix has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          fix: function( event ) {
        if ( event[ jQuery.expando ] ) {
            return event;
        }
      Severity: Minor
      Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

        Function clone has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            clone: function( elem, dataAndEvents, deepDataAndEvents ) {
        var i, l, srcElements, destElements,
            clone = elem.cloneNode( true ),
            inPage = jQuery.contains( elem.ownerDocument, elem );
        Severity: Minor
        Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( jQuery.isFunction( html ) ) {
            return this.each(function( i ) {
                jQuery( this ).wrapAll( html.call(this, i) );
            });
        }
          Severity: Major
          Found in bower_components/jquery/dist/jquery.js and 1 other location - About 1 hr to fix
          bower_components/jquery/dist/jquery.js on lines 8362..8366

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( jQuery.isFunction( html ) ) {
            return this.each(function( i ) {
                jQuery( this ).wrapInner( html.call(this, i) );
            });
        }
          Severity: Major
          Found in bower_components/jquery/dist/jquery.js and 1 other location - About 1 hr to fix
          bower_components/jquery/dist/jquery.js on lines 8332..8336

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function off has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              off: function( types, selector, fn ) {
        var handleObj, type;
        if ( types && types.preventDefault && types.handleObj ) {
            // ( event )  dispatched jQuery.Event
            handleObj = types.handleObj;
          Severity: Minor
          Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

            Function * has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    "*": [ function( prop, value ) {
            var tween = this.createTween( prop, value ),
                target = tween.cur(),
                parts = rfxnum.exec( value ),
                unit = parts && parts[ 3 ] || ( jQuery.cssNumber[ prop ] ? "" : "px" ),
            Severity: Minor
            Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

              Function offset has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  offset: function( options ) {
        if ( arguments.length ) {
            return options === undefined ?
                this :
                this.each(function( i ) {
              Severity: Minor
              Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

                Function Learn has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function Learn(learnJSON, config) {
        if (!(this instanceof Learn)) {
            return new Learn(learnJSON, config);
        }
                Severity: Minor
                Found in bower_components/todomvc-common/base.js - About 1 hr to fix

                  Consider simplifying this complex logical expression.
                  Open

                          if ( tokens.length > 2 && (token = tokens[0]).type === "ID" &&
                support.getById && context.nodeType === 9 && documentIsHTML &&
                Expr.relative[ tokens[1].type ] ) {

            context = ( Expr.find["ID"]( token.matches[0].replace(runescape, funescape), context ) || [] )[0];
                  Severity: Major
                  Found in bower_components/jquery/dist/jquery.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            "even": createPositionalPseudo(function( matchIndexes, length ) {
            var i = 0;
            for ( ; i < length; i += 2 ) {
                matchIndexes.push( i );
            }
                    Severity: Minor
                    Found in bower_components/jquery/dist/jquery.js and 1 other location - About 55 mins to fix
                    bower_components/jquery/dist/jquery.js on lines 1948..1954

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 54.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            "odd": createPositionalPseudo(function( matchIndexes, length ) {
            var i = 1;
            for ( ; i < length; i += 2 ) {
                matchIndexes.push( i );
            }
                    Severity: Minor
                    Found in bower_components/jquery/dist/jquery.js and 1 other location - About 55 mins to fix
                    bower_components/jquery/dist/jquery.js on lines 1940..1946

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 54.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function Todo has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function Todo() {
    var self = riot.observable(this),
        db = DB('riot-todo'),
        items = db.get();
                    Severity: Minor
                    Found in js/models/todo.js - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function access has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    var access = jQuery.access = function( elems, fn, key, value, chainable, emptyGet, raw ) {
                    Severity: Major
                    Found in bower_components/jquery/dist/jquery.js - About 50 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                          if ( ofType ? node.nodeName.toLowerCase() === name : node.nodeType === 1 ) {
                                        return false;
                                    }
                      Severity: Major
                      Found in bower_components/jquery/dist/jquery.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                        } else if ( copy !== undefined ) {
                    target[ name ] = copy;
                }
                        Severity: Major
                        Found in bower_components/jquery/dist/jquery.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  if ( attrs[ i ] ) {
                            name = attrs[ i ].name;
                            if ( name.indexOf( "data-" ) === 0 ) {
                                name = jQuery.camelCase( name.slice(5) );
                                dataAttr( elem, name, data[ name ] );
                          Severity: Major
                          Found in bower_components/jquery/dist/jquery.js - About 45 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language