3scale/porta

View on GitHub

Showing 5,267 of 5,597 total issues

Stats::Storage#compute_timeshift_deltas has the variable name 'i'
Open

        mget(*keys).in_groups_of(margin.count).map do |i|
Severity: Minor
Found in app/lib/stats/storage.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Storage#timeshift_values_by_deltas has the variable name 'i'
Open

        values.map do |value, i|
          current_delta = deltas.fetch(i, 0)
          next_delta = deltas.fetch(i+1, 0)

          if shift > 0
Severity: Minor
Found in app/lib/stats/storage.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::OAuth2 has the name 'OAuth2'
Open

  module OAuth2

An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Storage#granularity_to_hours has the parameter name 'g'
Open

    def granularity_to_hours(g)
Severity: Minor
Found in app/lib/stats/storage.rb by reek

An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Views::Usage#extract_range_and_granularity has the variable name 'e'
Open

      rescue ThreeScale::HashHacks::MissingKeyError => e
Severity: Minor
Found in app/lib/stats/views/usage.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::OAuth2 has the name 'OAuth2'
Open

  module OAuth2

An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::PrivateModule#PrivateModule#self.append_features has the variable name 'm'
Open

          @mods.each do |m|
Severity: Minor
Found in app/lib/three_scale/private_module.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::Swagger::Specification::V12 has the name 'V12'
Open

      class V12 < VBase

An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::Swagger::Translator#self.translate! has the variable name 't'
Open

        stages.map{|t| translator.send("#{t}_translator".to_sym)}

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::OAuth2::GitHubClient#primary_email has the variable name 'i'
Open

        primary = emails.find{ |i| i['primary'] && i['verified'] }

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::OAuth2 has the name 'OAuth2'
Open

  module OAuth2
Severity: Minor
Found in app/lib/three_scale/oauth2.rb by reek

An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

SendUserInvitationWorker has the variable name 'e'
Open

  rescue_from ActiveJob::DeserializationError do |e|

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

NotificationMailer has the variable name 'h'
Open

  self.event_mapping = Hash.new { |h, k| h[k] = [] }
Severity: Minor
Found in app/mailers/notification_mailer.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::SSO::Encryptor#extract! has the variable name 't'
Open

        generation_time, expiration_time = raw.map{ |t| Time.at(t.to_f) }
Severity: Minor
Found in app/lib/three_scale/sso.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::OAuth2 has the name 'OAuth2'
Open

  module OAuth2

An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ProcessNotificationEventWorker#create_notifications has the variable name 'e'
Open

  rescue ActiveRecord::RecordNotFound => e

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CreateContracts#self.up has the variable name 't'
Open

    create_table :contracts do |t|
Severity: Minor
Found in db/migrate/011_create_contracts.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::Swagger::Translator#operations has the variable name 'w'
Open

        @_ops ||= swagger.fetch('apis',[]).flat_map{ |w| w['operations'] }.compact

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::OAuth2 has the name 'OAuth2'
Open

  module OAuth2

An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::PrivateModule#PrivateModule has the name 'PrivateModule'
Open

    def PrivateModule(*modules)
Severity: Minor
Found in app/lib/three_scale/private_module.rb by reek

An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Severity
Category
Status
Source
Language