3scale/porta

View on GitHub

Showing 5,267 of 5,597 total issues

Logic::RollingUpdates::Features::ApicastV2 has the name 'ApicastV2'
Open

      class ApicastV2 < Base
Severity: Minor
Found in app/lib/logic/rolling_updates.rb by reek

An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Finance::Builder::XmlMarkup#self.invoices! has the variable name 'i'
Open

      items.each { |i| i.to_xml(:builder => xml ) }
Severity: Minor
Found in app/lib/finance/builder/xml_markup.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

PaymentGateways::AuthorizeNetCimCrypt#get_token has the variable name 'e'
Open

      rescue SocketError => e

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Finance::VariableCost#bill_variable_fee_for has the variable name 'm'
Open

      variable_cost = variable_cost.select { |metric,cost|  cost.nonzero? }.sort_by { |m,cost| -cost }
Severity: Minor
Found in app/lib/finance/variable_cost.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

SimpleLayout#build_builtin_static_page has the variable name 'l'
Open

    provider.builtin_static_pages.build do |l|
Severity: Minor
Found in app/lib/simple_layout.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

SimpleLayout#create_builtin_pages_and_partials! has the variable name 'p'
Open

    p = provider.builtin_pages
Severity: Minor
Found in app/lib/simple_layout.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Fields::ExtraFields#read_attribute_for_validation has the variable name 'e'
Open

  rescue LoadError => e
Severity: Minor
Found in app/lib/fields/extra_fields.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

SimpleLayout#create_builtin_partial! has the variable name 'p'
Open

      provider.builtin_partials.create! do |p|
Severity: Minor
Found in app/lib/simple_layout.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

SimpleLayout#setup_main_layout! has the variable name 'p'
Open

                               liquid_enabled: true).tap { |p| p.publish! }
Severity: Minor
Found in app/lib/simple_layout.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Views::Csv::Metrics#collection has the variable name 'm'
Open

            @data[:metrics].collect do |m|
Severity: Minor
Found in app/lib/stats/views/csv/metrics.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ServiceDiscovery::WellKnownFetcher#call has the variable name 'e'
Open

    rescue => e

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Storage#resum_all_value has the variable name 'g'
Open

      g = granularity_to_seconds(granularity)
Severity: Minor
Found in app/lib/stats/storage.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Base#extract_metric has the variable name 'm'
Open

               elsif m = metrics.find_by_system_name(options[:metric_name])
Severity: Minor
Found in app/lib/stats/base.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Storage#granularity_to_seconds has the parameter name 'g'
Open

    def granularity_to_seconds(g)
Severity: Minor
Found in app/lib/stats/storage.rb by reek

An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

PaymentGateways::PaymentGatewayCrypt#notify_exception has the parameter name 'e'
Open

    def notify_exception(e, query_string = nil)

An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Logic::RollingUpdates::Provider#provider_can_use? has the variable name 'e'
Open

      rescue StandardError => e
Severity: Minor
Found in app/lib/logic/rolling_updates.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Storage#ordered_hash has the variable name 'e'
Open

      rescue RuntimeError => e # "no such key" for example
Severity: Minor
Found in app/lib/stats/storage.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Storage#resum_all_value has the variable name 'v'
Open

        mget(*keys).inject(0) { |sum,v| sum + v.to_i }
Severity: Minor
Found in app/lib/stats/storage.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::Diff#chunked has the variable name 'e'
Open

      what.split(/\n/).map { |e| e.chomp }
Severity: Minor
Found in app/lib/three_scale/diff.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ThreeScale::Analytics::UserTracking#extended_traits has the variable name 'o'
Open

             deployment_option: deployment_options.group_by{|o| o }.values.max_by(&:size).try!(:first),

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Severity
Category
Status
Source
Language