Sign upLogin

3scale/porta

View on GitHub
Star

Showing 5,267 of 5,597 total issues

CreateSSOAuthorizations#change has the variable name 't'
Open

    create_table :sso_authorizations do |t|
Severity: Minor
Found in db/migrate/20170306162323_create_sso_authorizations.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

RemovingBcmsTables#self.down has the variable name 't'
Open

    create_table "account_group_memberships", :force => true do |t|
      t.integer "account_id", :limit => 8
      t.integer "group_id",   :limit => 8
      t.integer "tenant_id",  :limit => 8
    end
Severity: Minor
Found in db/migrate/20121018100514_removing_bcms_tables.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

AddSupportEmailToServices#self.down has the variable name 's'
Open

    change_table :services do |s|
Severity: Minor
Found in db/migrate/20131112150455_add_support_email_to_services.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CreateBackendEvents#change has the variable name 't'
Open

    create_table :backend_events, id: false do |t|
Severity: Minor
Found in db/migrate/20150518145034_create_backend_events.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ConvertEventStoreEventsToUtf8 has the name 'ConvertEventStoreEventsToUtf8'
Open

class ConvertEventStoreEventsToUtf8 < ActiveRecord::Migration
Severity: Minor
Found in db/migrate/20160803155532_convert_event_store_events_to_utf8.rb by reek

An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

FixGroupSections#self.down has the variable name 't'
Open

    create_table "cms_group_sections", :force => true do |t|
Severity: Minor
Found in db/migrate/20121018113624_fix_group_sections.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CreateNotifications#change has the variable name 't'
Open

    create_table :notifications do |t|
Severity: Minor
Found in db/migrate/20160502152346_create_notifications.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CreateServiceTokens#change has the variable name 't'
Open

    create_table :service_tokens do |t|
Severity: Minor
Found in db/migrate/20160606090533_create_service_tokens.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

assert_line_items has the variable name 'i'
Open

  items.hashes.each_with_index do |line, i|
Severity: Minor
Found in features/step_definitions/finance/invoicing_steps.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

DeveloperPortal::Admin::Account::AuthorizeNetController#show has the variable name 'e'
Open

    rescue ::PaymentGateways::PaymentGatewayDown, ::PaymentGateways::IncorrectKeys => e
Severity: Minor
Found in lib/developer_portal/app/controllers/developer_portal/admin/account/authorize_net_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Unused#self.replace_step_file has the variable name 'l'
Open

    File.new(name).each_line.with_index do |l,i|
Severity: Minor
Found in features/support/unused.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Unused#print_summary has the variable name 'b'
Open

    keys = @stepdef_to_match.keys.sort {|a,b| a.regexp_source <=> b.regexp_source}
Severity: Minor
Found in features/support/unused.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

selector_for_table_row_with_cells has the variable name 'x'
Open

    tds = cells.map{|cell| XPath.generate { |x| x.child(:td)[x.string.contains(cell)] } }.reduce(:+)
    XPath.generate { |x| x.anywhere[ tds ] }.to_s
Severity: Minor
Found in features/support/tables.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

DummyAttachments#dummy_css has the variable name 'f'
Open

    f = File.new(dummy_css_filename)
Severity: Minor
Found in features/support/dummy_attachments.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Unused#print_summary has the variable name 'a'
Open

    keys = @stepdef_to_match.keys.sort {|a,b| a.regexp_source <=> b.regexp_source}
Severity: Minor
Found in features/support/unused.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Unused#self.replace_step_file has the variable name 'i'
Open

    File.new(name).each_line.with_index do |l,i|
Severity: Minor
Found in features/support/unused.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Liquid::Filters::ParamFilter#to_param has the variable name 'd'
Open

          drop.map { |d| to_param(d) }.join('&')
Severity: Minor
Found in lib/developer_portal/lib/liquid/filters/param_filter.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CMS::Toolbar::Renderer#assigns has the variable name 't'
Open

      liquids = @liquids.try(:map){ |t| t.registers[:file_system].try(:history) } || []
Severity: Minor
Found in lib/developer_portal/lib/cms/toolbar/renderer.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Liquid::Docs::DSL::Drops::Documentation#add_method has the variable name 'm'
Open

            if i = methods.find_index { |m| m.name == name }
Severity: Minor
Found in lib/developer_portal/lib/liquid/docs/dsl/drops.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Liquid::Drops::Collection#has_key? has the variable name 'o'
Open

        any? { |o| o.respond_to?(:system_name) && o.system_name == key }
Severity: Minor
Found in lib/developer_portal/lib/liquid/drops/collection.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Severity
Category
Status
Source
Language