Showing 5,267 of 5,597 total issues
Liquid::Tags::Form#render has the variable name 'k' Open
form = form_class.new(context, @object_name, @html_attributes.inject({}){|result, (k,v)| result[k] = v.render(context); result} )- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Arel::Visitors#visit_Arel_Nodes_NotIn has the parameter name 'o' Open
def visit_Arel_Nodes_NotIn(o, collector)- Read upRead up
- Exclude checks
An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Drops::BillingAddress#address2 has the name 'address2' Open
def address2- Read upRead up
- Exclude checks
An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Docs::DSL::Tags::Documentation#to_markdown has the variable name 'e' Open
@examples.each do |e|- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Drops::Collection#[] has the variable name 'o' Open
find { |o| o.respond_to?(:system_name) && o.system_name == key } || super- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Drops::Deprecated has the variable name 'm' Open
((private_instance_methods + instance_methods).map(&:to_sym) - KEEP_METHODS).each{|m| undef_method(m) }- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Migration::Finance#self.freeze_closed_invoices has the variable name 'e' Open
rescue => e- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
last_admin_access_of has the variable name 'u' Open
provider.users.impersonation_admins.map{|u| u.user_sessions.last.try!(:accessed_at)}.compact.max- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Drops::Field#choices has the variable name 'c' Open
@choices ||= @field.choices.map { |c| Choice.new(c) }- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Arel::Visitors#visit_Arel_Nodes_Equality has the parameter name 'o' Open
def visit_Arel_Nodes_Equality(o, collector)- Read upRead up
- Exclude checks
An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Drops::BillingAddress#address1 has the name 'address1' Open
def address1- Read upRead up
- Exclude checks
An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Drops::NewSignup#services has the variable name 's' Open
@provider.services.map { |s| @wrapper.wrap_service(s) }- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Arel::Visitors#strip_order_from_select has the parameter name 'o' Open
def strip_order_from_select(o)- Read upRead up
- Exclude checks
An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Docs::Generator#to_html has the variable name 't' Open
list_items = toc.map do |t|- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Drops::CountryField#choices has the variable name 'c' Open
@choices = ::Country.all.map { |c| Choice.new(c.name, c.id) }- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
ProgressCounter#initialize has the variable name 'e' Open
spinner = Enumerator.new do |e|- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Docs::DSL::Drops::Documentation#add_method has the variable name 'i' Open
if i = methods.find_index { |m| m.name == name }- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Liquid::Tags::ActiveDocs#render has the variable name 'e' Open
.select{|e| e.specification.swagger_2_0?}.map(&:system_name)- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Arel::Visitors#visit_Arel_Nodes_Equality has the name 'visit_Arel_Nodes_Equality' Open
def visit_Arel_Nodes_Equality(o, collector)- Read upRead up
- Exclude checks
An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
Gitlab::Testing::RequestInspectorMiddleware#http_headers_env has the variable name 'v' Open
.collect { |k, v| [k.split('-').collect(&:upcase).join('_'), v] }
.collect { |k, v| [k.prepend('HTTP_'), v] }- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.