520MianXiangDuiXiang520/JuneGoBlog

View on GitHub
src/dao/article.go

Summary

Maintainability
C
7 hrs
Test Coverage

File article.go has 550 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package dao

import (
    "JuneGoBlog/src"
    "JuneGoBlog/src/consts"
Severity: Minor
Found in src/dao/article.go - About 3 hrs to fix

    Function queryArticleInfoFromCache has 65 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func queryArticleInfoFromCache(id int) (ArticleListInfo, error) {
        var fields = []string{
            "Title", "Abstract", "ID", "CreateTime", "Tags",
        }
        result := ArticleListInfo{}
    Severity: Minor
    Found in src/dao/article.go - About 1 hr to fix

      Function queryArticleInfoFromCache has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
      Open

      func queryArticleInfoFromCache(id int) (ArticleListInfo, error) {
          var fields = []string{
              "Title", "Abstract", "ID", "CreateTime", "Tags",
          }
          result := ArticleListInfo{}
      Severity: Minor
      Found in src/dao/article.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function AddArticle has 6 return statements (exceeds 4 allowed).
      Open

      func AddArticle(newArticle *Article, tagIDs []int) (*Article, error) {
          tx := juneDao.GetDB().Begin()
          var err error
          defer func() {
              if err != nil {
      Severity: Major
      Found in src/dao/article.go - About 40 mins to fix

        Function QueryArticleInfoByLimit has 5 return statements (exceeds 4 allowed).
        Open

        func QueryArticleInfoByLimit(page, pageSize int) ([]ArticleListInfo, int, error) {
            total, err := QueryArticleTotal()
            if err != nil {
                return nil, 0, err
            }
        Severity: Major
        Found in src/dao/article.go - About 35 mins to fix

          Function queryArticleIDListFromCache has 5 return statements (exceeds 4 allowed).
          Open

          func queryArticleIDListFromCache(page, pageSize, total int) ([]int, error) {
              start := (page-1)*pageSize + 1
              r := make([]int, 0)
              rc := juneDao.GetRedisConn()
              defer rc.Close()
          Severity: Major
          Found in src/dao/article.go - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status