Showing 1,189 of 1,190 total issues
File ExportController.php
has 282 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace App\Http\Controllers\Admin;
use App\Enums\ColumnType;
Method rss
has 69 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function rss(Request $request): Response
{
$db = app(DbService::class);
$db->addLoadedTable('bind', 'files', 'kat', 'maerke', 'sider');
File invoice.js
has 279 lines of code (exceeds 250 allowed). Consider refactoring. Open
import xHttp from "../xHttp.js";
import {genericCallback, reloadCallback, getSelectValue} from "./javascript.js";
import {getAddress, changeZipCode} from "../getAddress.js";
var invoiceLines = [];
Method mismatchedBindings
has 67 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function mismatchedBindings(): JsonResponse
{
$html = '';
// Map out active / inactive
File InvoicePdfService.php
has 276 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace App\Services;
use App\Countries;
Function update
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
public function update(Request $request, int $id): JsonResponse
{
$orm = app(OrmService::class);
$category = $orm->getOne(Category::class, $id);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function generateFilterInvoiceBySelection
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
private function generateFilterInvoiceBySelection(InvoiceFilter $selected, User $user): string
{
if ($selected->id) {
return 'WHERE `id` = ' . $selected->id;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method findPages
has 60 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function findPages(
string $searchString,
int $brandId,
string $varenr = '',
int $minpris = 0,
Similar blocks of code found in 2 locations. Consider refactoring. Open
$this->setTimestamp(intval($data['timestamp'] ?? time()))
->setName(strval($data['name']))
->setEmail(strval($data['email']))
->setAddress(strval($data['address']))
->setCountry(strval($data['country']))
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 129.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
$this->setTimestamp(intval($data['timestamp'] ?? time()))
->setSubject(strval($data['subject']))
->setBody(strval($data['body']))
->setSenderName(strval($data['senderName']))
->setSenderAddress(strval($data['senderAddress']))
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 129.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method getDbArray
has 59 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getDbArray(): array
{
$itemQuantities = [];
$itemTitle = [];
$itemValue = [];
Method buildSearchQuery
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function buildSearchQuery(string $qpath, string $qalt, string $qtype): string
{
$db = app(DbService::class);
$qpath = $db->escapeWildcards($qpath);
$qalt = $db->escapeWildcards($qalt);
File Category.php
has 262 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace App\Models;
use App\Exceptions\InvalidInput;
Function setItemData
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
public function setItemData(string $itemData): self
{
$this->items = [];
$items = json_decode($itemData, true);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function index(Request $request): Response
{
$momssats = strval($request->get('momssats'));
if (!$momssats) {
$momssats = null;
Function save
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
function save(id = null, type = null) {
if (type === "cancel" && !confirm("Are you sure you want to cancel this Invoice?")) {
return false;
}
Method mapFromDB
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function mapFromDB(array $data): array
{
$itemQuantities = explode('<', $data['quantities']);
$itemQuantities = array_map('intval', $itemQuantities);
$itemValue = explode('<', $data['values']);
File
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class File extends AbstractEntity
{
/** Table name in database. */
public const TABLE_NAME = 'files';
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function __construct(array $data = [])
{
$this->setPageId(intval($data['page_id']))
->setTitle(strval($data['title']))
->setColumnData(strval($data['column_data']))
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 123.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function __construct(array $data = [])
{
$this->setFullName(strval($data['full_name']))
->setNickname(strval($data['nickname']))
->setPasswordHash(strval($data['password_hash']))
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 123.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76